Skip to content

New login form layout#2139

Merged
rdwebdesign merged 4 commits into
develfrom
new_login_form
Mar 8, 2022
Merged

New login form layout#2139
rdwebdesign merged 4 commits into
develfrom
new_login_form

Conversation

@rdwebdesign
Copy link
Copy Markdown
Member

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

What does this PR aim to accomplish?:

The current login form has a few visual issues:

  • text has many line breaks (using boxed layout or medium size screens);
  • the "Remember me for 7 days" checkbox should be before the "Log in" button;
  • the help text uses a list format, with bullet points;

How does this PR accomplish the above?:

  • Password input resized;
  • checkbox moved;
  • text rearranged and resized to avoid line breaks whenever possible;

new_loginpage

What documentation changes (if any) are needed to support this PR?:

none.

@rdwebdesign rdwebdesign requested a review from a team March 3, 2022 23:24
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@PromoFaux
Copy link
Copy Markdown
Member

I like it, might just be my eye, but does it look slightly off on mobile?

image

@rdwebdesign
Copy link
Copy Markdown
Member Author

... it look slightly off on mobile?

Yes and no.
The elements are aligned, but this theme (Pi-hole midnight theme) uses a transparent border for the input field.
login_alignment

When the field gets focus, the border turn blue and all appears aligned again.

I need to fine tune this effect, but only for this theme.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
PromoFaux
PromoFaux previously approved these changes Mar 6, 2022
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign merged commit 8563eea into devel Mar 8, 2022
@rdwebdesign rdwebdesign deleted the new_login_form branch March 8, 2022 16:13
@pralor-bot
Copy link
Copy Markdown

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-ftl-v5-15-web-v5-12-and-core-v5-10-released/54987/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants