Conversation
Member
Author
|
@sinisaos We need this change, because that's why in this PR it was redirecting to the login page if there was an error in the change password form: |
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
=======================================
Coverage 88.38% 88.38%
=======================================
Files 29 29
Lines 1576 1576
=======================================
Hits 1393 1393
Misses 183 183
Continue to review full report at Codecov.
|
Member
|
@dantownsend This is great and should work. |
Member
Author
|
@sinisaos Cool - I'll release this, then will release the change password feature in Piccolo Admin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the HTTP status codes were incorrect - the endpoints were returning 401, which means permission denied, when 422 is more appropriate, as they are validation errors.
This is important for Piccolo Admin, as we configure axios to intercept any 401 errors, and redirect to the login page.