Improve rate limit handling #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2025
mschoettle
commented
May 16, 2025
src/index.ts
Outdated
| return true; | ||
| }, | ||
| minimumAbuseRetryAfter: 1000, | ||
| fallbackSecondaryRateRetryAfter: 120, |
Contributor
Author
There was a problem hiding this comment.
It always takes several rounds of waiting 120s so it could be higher by default.
Suggested change
| fallbackSecondaryRateRetryAfter: 120, | |
| fallbackSecondaryRateRetryAfter: 1200, |
Member
There was a problem hiding this comment.
It feels like a big jump from 2 min to 20. I haven't run into this ratelimit yet and have no experience if this or which value makes sense. Maybe 5 min instead?
Contributor
Author
There was a problem hiding this comment.
For me it only happens when migrating MRs with a lot of comments/discussions. If I remember correctly it takes about 20 to 30 minutes to run again. 5 minutes is a good balance I think since it will retry until it works. If it's 30 and we retry after 20 minutes it will wait 40 minutes in total.
spruce
reviewed
May 21, 2025
mschoettle
force-pushed
the
upgrade-octokit
branch
from
09a947d to
c7308d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade octokit packages. In particular,
plugin-throttlingwhich handles the current best practices in avoiding being rate limited.Fixes #189
Fixes #90
Should also fix #222