fix: Consolidate duplicate types, fix stale docs and confused comments#11
Open
avi8or wants to merge 1 commit into
Open
fix: Consolidate duplicate types, fix stale docs and confused comments#11avi8or wants to merge 1 commit into
avi8or wants to merge 1 commit into
Conversation
- CurrentTask and ConflictInfo are defined in both task_storage.py and
task_reconciliation.py with different fields. Consolidated both into
task_storage.py so there's a single definition to maintain.
- generate-section-tasks.py has a comment block that reads like
stream-of-consciousness notes ("Actually", "No wait", "Let me check").
Replaced with a clean summary of the position mapping formula.
- section-index.md says both PROJECT_CONFIG and SECTION_MANIFEST blocks
"MUST start" the file, which is contradictory. Clarified ordering.
- section-splitting.md describes the SubagentStop hook as parsing JSON
with sections_dir/filename/content fields, but the actual hook
extracts the prompt path and writes the last assistant message as raw
markdown. Updated to match what the hook actually does.
All 341 existing tests pass.
avi8or
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 341 existing tests pass.