fix: regex null safety, elapsed time unit, and remove dead code#12
Open
avi8or wants to merge 1 commit into
Open
fix: regex null safety, elapsed time unit, and remove dead code#12avi8or wants to merge 1 commit into
avi8or wants to merge 1 commit into
Conversation
- The section sorting in sections.py assumes every filename matches the expected pattern, but if one doesn't, it blows up with an AttributeError on None. Added a small helper that safely returns 0 for anything that doesn't match. - The stability wait log in write-section-on-stop.py says "ms" but the actual value is in seconds, so it always shows something like "0ms" even when it waited a full second. Multiplied by 1000 so the log is accurate. - needs_migration() in task_storage.py isn't called from anywhere. Removed it to keep things clean. All 339 existing tests pass.
avi8or
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The section sorting in sections.py assumes every filename matches the expected pattern, but if one doesn't, it blows up with an AttributeError on None. Added a small helper that safely returns 0 for anything that doesn't match.
The stability wait log in write-section-on-stop.py says "ms" but the actual value is in seconds, so it always shows something like "0ms" even when it waited a full second. Multiplied by 1000 so the log is accurate.
needs_migration() in task_storage.py isn't called from anywhere. Removed it to keep things clean. Maybe left over from early days?
All 339 existing tests pass.