-
Notifications
You must be signed in to change notification settings - Fork 8
Virtualization V1 #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amadeus
wants to merge
41
commits into
main
Choose a base branch
from
amadeus/virtualization-v1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Virtualization V1 #244
+929,881
−56,810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6cca062 to
9a479dd
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
945184c to
c878b0b
Compare
c878b0b to
e53f541
Compare
893431f to
d125f9a
Compare
d125f9a to
b786379
Compare
e7ed2c2 to
b537069
Compare
c90d89f to
e22d31a
Compare
e22d31a to
9b54f7c
Compare
Extremely helpful for debugging
Apparently this lil line caused us 50 years :kek: tbh, it's not really needed anymore, the new system is far more efficient now and it was a redundent line anyways...
This will make things a lot easier and more predictable to math when iterating
Another aspect that can allow us to make better line calculations
Basically we should not try to infer it from the rendered AST since windowing can break this, so in prep for improved virtualization/windowing we'll instead infer it from the diff directly.
9b54f7c to
f9ed9c6
Compare
Still needs more AI slop removed, but this is finally the working proof that this shit can wooork
f9ed9c6 to
8b942a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature branch to work through supporting virtualization.