Add missing pcre dependency definition to zip extension #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zip extension also requires the pcre extension.
remicollet
reviewed
Jun 3, 2024
| /* {{{ zip_module_entry */ | ||
| zend_module_entry zip_module_entry = { | ||
| STANDARD_MODULE_HEADER, | ||
| "zip", |
Collaborator
There was a problem hiding this comment.
This one should not be removed ;)
Contributor
Author
There was a problem hiding this comment.
Ah, indeed. Thanks. I've pasted it too quickly.
Collaborator
|
Fix and applied to all versions in d66c502 Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zip extension also requires the pcre extension.