Fix throwing when there's an assertion error #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! |
Contributor
Author
|
it works! tested with with async and non-async assert functions on my project. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, sorry, I submitted a bad patch before, which incorrectly would mark tests as passed.
here's an example where you can see error messages in the tests, but they still pass
https://github.com/fent/node-ytdl-core/pull/611/checks?check_run_id=586823832#step:5:251
hopefully this new patch rectifies the issue. please look at it thoroughly if I've missed anything. and again, sorry about this mistake. I can only imagine the missed tests from this v_v
(if the ternary style looks too weird, I can change it to an
if else.