Update usage of Shout #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shout implements code to deal with fonts but this code is never used and probably do not work with Pharo's scaling and other features. To simplify Shout this will probably be removed leading to the removal of #initialTextAttributesForPixelHeight:. Since Microdown is using this method, I propose an alternative way to update the behavior of Microdown styler to allow the refactor of Shout.
demarey
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shout implements code to deal with fonts but this code is never used and probably do not work with Pharo's scaling and other features. To simplify Shout this will probably be removed leading to the removal of #initialTextAttributesForPixelHeight:.
Since Microdown is using this method, I propose an alternative way to update the behavior of Microdown styler to allow the refactor of Shout.