Issue 845 more annotated paragraph #857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ducasse
reviewed
Aug 15, 2024
| self assert: result trimBoth equals: '<h1>This is a title</h1>', newLine , | ||
| '<section id="LabelOfAnnotatedBlock"><label for="LabelOfAnnotatedBlock">Body of annotated block</label></section>', newLine , | ||
| '<p>this is another string</p>'. | ||
| self |
Contributor
There was a problem hiding this comment.
To me it looks strange to create a heading 1 for a note.
Why did you suggest this?
Contributor
There was a problem hiding this comment.
And we can let it for now and see later.
Contributor
Author
There was a problem hiding this comment.
The test with h1 already exist when I have adding the verifiedLabels. I only correct the test for let him pass green
Ducasse
reviewed
Aug 15, 2024
| MicAnnotatedParagraph >> initialize [ | ||
|
|
||
| super initialize. | ||
| validLabel := { #note . #important . #todo } |
Contributor
There was a problem hiding this comment.
Could use plurals eg validLabels
Tx
Contributor
|
Thanks for the explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #845
I add valid label and a default label. If the label is not a valid label, then we use the default label