feat/PRO-2482/exchange-cross-chain-cleanup#100
Merged
Conversation
Deploying x with
|
| Latest commit: |
5140c95
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f6ba99ca.x-e62.pages.dev |
| Branch Preview URL: | https://feat-pro-2482-exchange-cross.x-e62.pages.dev |
IAmKio
requested changes
Jul 4, 2024
Collaborator
IAmKio
left a comment
There was a problem hiding this comment.
Fantastic work! 🚀 It's been a really bumpy ride but we're very nearly there - just a few bits to sort out here and there then we can launch the first first-party PillarX app 🔥 can't wait!
Collaborator
There was a problem hiding this comment.
Many developers will look at this file to see how you did swaps - it may be worth writing a JSDoc block about the app and what it does to guide other developers 🙏
429f18f to
0673d7b
Compare
IAmKio
approved these changes
Jul 10, 2024
Collaborator
IAmKio
left a comment
There was a problem hiding this comment.
LGTM - great work on building PillarX's first first-party app! 🚀 🔥
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes