Skip to content

feat/PRO-2482/exchange-cross-chain-cleanup#100

Merged
RanaBug merged 15 commits intostagingfrom
feat/PRO-2482/exchange-cross-chain-cleanup
Jul 10, 2024
Merged

feat/PRO-2482/exchange-cross-chain-cleanup#100
RanaBug merged 15 commits intostagingfrom
feat/PRO-2482/exchange-cross-chain-cleanup

Conversation

@RanaBug
Copy link
Collaborator

@RanaBug RanaBug commented Jul 4, 2024

Description

  • Big FE cleanup for a smoother user experience, with error and loading handling
  • Added hooks to handle the swap calls
  • Cross chain and same chain swaps are now possible on the app

How Has This Been Tested?

  • End to end testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@RanaBug RanaBug requested a review from IAmKio July 4, 2024 15:52
@RanaBug RanaBug self-assigned this Jul 4, 2024
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 4, 2024

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5140c95
Status: ✅  Deploy successful!
Preview URL: https://f6ba99ca.x-e62.pages.dev
Branch Preview URL: https://feat-pro-2482-exchange-cross.x-e62.pages.dev

View logs

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! 🚀 It's been a really bumpy ride but we're very nearly there - just a few bits to sort out here and there then we can launch the first first-party PillarX app 🔥 can't wait!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many developers will look at this file to see how you did swaps - it may be worth writing a JSDoc block about the app and what it does to guide other developers 🙏

@github-actions github-actions bot temporarily deployed to Preview (feat/PRO-2482/exchange-cross-chain-cleanup) July 5, 2024 15:38 Inactive
@github-actions github-actions bot temporarily deployed to Preview (feat/PRO-2482/exchange-cross-chain-cleanup) July 8, 2024 16:51 Inactive
@github-actions github-actions bot temporarily deployed to Preview (feat/PRO-2482/exchange-cross-chain-cleanup) July 8, 2024 18:36 Inactive
@RanaBug RanaBug force-pushed the feat/PRO-2482/exchange-cross-chain-cleanup branch from 429f18f to 0673d7b Compare July 9, 2024 10:30
@github-actions github-actions bot requested a deployment to Preview (feat/PRO-2482/exchange-cross-chain-cleanup) July 9, 2024 10:30 Abandoned
@github-actions github-actions bot requested a deployment to Preview (feat/PRO-2482/exchange-cross-chain-cleanup) July 9, 2024 10:42 Abandoned
@github-actions github-actions bot requested a deployment to Preview (feat/PRO-2482/exchange-cross-chain-cleanup) July 9, 2024 18:19 Abandoned
@github-actions github-actions bot requested a deployment to Preview (feat/PRO-2482/exchange-cross-chain-cleanup) July 9, 2024 18:34 Abandoned
@github-actions github-actions bot requested a deployment to Preview (feat/PRO-2482/exchange-cross-chain-cleanup) July 9, 2024 18:56 Abandoned
Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - great work on building PillarX's first first-party app! 🚀 🔥

@RanaBug RanaBug merged commit c089c7a into staging Jul 10, 2024
@IAmKio IAmKio deleted the feat/PRO-2482/exchange-cross-chain-cleanup branch July 11, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants