Skip to content

feature/core-api-config#102

Merged
IAmKio merged 2 commits intostagingfrom
feature/core-api-config
Jul 11, 2024
Merged

feature/core-api-config#102
IAmKio merged 2 commits intostagingfrom
feature/core-api-config

Conversation

@IAmKio
Copy link
Collaborator

@IAmKio IAmKio commented Jul 11, 2024

Description

  • Added testnet switching via environment variables to allow core APIs to switch URLs depending on whether they are in testnet mode or not.

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@IAmKio IAmKio requested a review from RanaBug July 11, 2024 08:08
@IAmKio IAmKio self-assigned this Jul 11, 2024
baseQuery: fetchBaseQuery({ baseUrl:
process.env.REACT_APP_USE_TESTNETS === 'true' ?
'https://feed-nubpgwxpiq-uc.a.run.app/' :
'https://feed-7eu4izffpa-uc.a.run.app'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one url has '/' at the end and one does not, I believe both needs '/' no?

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 11, 2024

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8503a7b
Status: ✅  Deploy successful!
Preview URL: https://d1ba57da.x-e62.pages.dev
Branch Preview URL: https://feature-core-api-config.x-e62.pages.dev

View logs

@IAmKio IAmKio merged commit 3d76523 into staging Jul 11, 2024
@IAmKio IAmKio deleted the feature/core-api-config branch July 11, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants