Skip to content

feat/PRO-2403/tile-generic-banner#105

Merged
RanaBug merged 2 commits intostagingfrom
feat/PRO-2403/tile-generic-banner
Jul 15, 2024
Merged

feat/PRO-2403/tile-generic-banner#105
RanaBug merged 2 commits intostagingfrom
feat/PRO-2403/tile-generic-banner

Conversation

@RanaBug
Copy link
Collaborator

@RanaBug RanaBug commented Jul 15, 2024

Description

  • FE implementation of the Generic Banner Tile component

How Has This Been Tested?

  • Unit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@RanaBug RanaBug requested a review from IAmKio July 15, 2024 14:09
@RanaBug RanaBug self-assigned this Jul 15, 2024
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 15, 2024

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: d561ccb
Status: ✅  Deploy successful!
Preview URL: https://db628450.x-e62.pages.dev
Branch Preview URL: https://feat-pro-2403-tile-generic-b.x-e62.pages.dev

View logs

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpick and a question, other than that all good!

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - another tile in the bag! 🚀

@RanaBug RanaBug merged commit 975fe3d into staging Jul 15, 2024
@RanaBug RanaBug deleted the feat/PRO-2403/tile-generic-banner branch April 3, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants