Skip to content

fix/PRO-2505/wallet-overview-empty-state#106

Merged
RanaBug merged 2 commits intostagingfrom
fix/PRO-2505/wallet-overview-empty-state
Jul 16, 2024
Merged

fix/PRO-2505/wallet-overview-empty-state#106
RanaBug merged 2 commits intostagingfrom
fix/PRO-2505/wallet-overview-empty-state

Conversation

@RanaBug
Copy link
Collaborator

@RanaBug RanaBug commented Jul 15, 2024

Description

  • Update empty state of portfolio overview tile when no tokens in wallet
  • Fix of the api call to avoid portfolio overview to be empty, while it actually has data

How Has This Been Tested?

  • Run of existing unit tests and end to end test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@RanaBug RanaBug requested a review from IAmKio July 15, 2024 17:32
@RanaBug RanaBug self-assigned this Jul 15, 2024
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 15, 2024

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0a5c555
Status: ✅  Deploy successful!
Preview URL: https://89628c91.x-e62.pages.dev
Branch Preview URL: https://fix-pro-2505-wallet-overview.x-e62.pages.dev

View logs

const { data: apiData, isLoading: isApiLoading, isFetching, isSuccess } = useGetTilesInfoQuery( { page: page, address: walletAddress || '' });

// The API call will not fire if there is no walletAddress
const { data: apiData, isLoading: isApiLoading, isFetching, isSuccess } = useGetTilesInfoQuery( { page: page, address: walletAddress || '' }, { skip: !walletAddress });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RanaBug RanaBug merged commit 276a020 into staging Jul 16, 2024
@RanaBug RanaBug deleted the fix/PRO-2505/wallet-overview-empty-state branch April 3, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants