Skip to content

fix/PRO-2535/usd-conversion-and-offer-fix#122

Merged
RanaBug merged 2 commits intostagingfrom
fix/PRO-2535/usd-conversion-and-offer-fix
Jul 24, 2024
Merged

fix/PRO-2535/usd-conversion-and-offer-fix#122
RanaBug merged 2 commits intostagingfrom
fix/PRO-2535/usd-conversion-and-offer-fix

Conversation

@RanaBug
Copy link
Collaborator

@RanaBug RanaBug commented Jul 24, 2024

Description

  • USD conversion now updates when changing tokens or swapping tokens
  • Exchange button is not clickable anymore if there is no offer or if the offer is loading - better state management of this CTA
  • TokenVerticalList is not showing token logos

How Has This Been Tested?

  • Update Unit Test and manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@RanaBug RanaBug requested a review from IAmKio July 24, 2024 14:04
@RanaBug RanaBug self-assigned this Jul 24, 2024
<div className={`flex flex-col flex-1 mobile:p-0 mobile:border-0 ${position === 'left' ? 'pr-10 border-r-[3px] border-[#1F1D23]' : 'pl-10'}`}>
{data.map((token, index) =>
<HorizontalToken key={index} tokenIndex={index + listStartIndex} tokenName={token.name} tokenSymbol={token.symbol} tokenValue={undefined} percentage={undefined} isLast={index === data.length - 1}/>
<HorizontalToken key={index} tokenIndex={index + listStartIndex} tokenName={token.name} tokenSymbol={token.symbol} tokenValue={undefined} percentage={undefined} isLast={index === data.length - 1} tokenLogo={token.logo} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note - consider the spread operator in future

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 24, 2024

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8910d3e
Status: ✅  Deploy successful!
Preview URL: https://d0a7c929.x-e62.pages.dev
Branch Preview URL: https://fix-pro-2535-usd-conversion.x-e62.pages.dev

View logs

@RanaBug RanaBug merged commit 59b510c into staging Jul 24, 2024
@RanaBug RanaBug deleted the fix/PRO-2535/usd-conversion-and-offer-fix branch April 3, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants