Skip to content

fix/PRO-2560/big-screen-scrolling-max-width#128

Merged
RanaBug merged 1 commit intostagingfrom
fix/PRO-2560/big-screen-scrolling-max-width
Jul 31, 2024
Merged

fix/PRO-2560/big-screen-scrolling-max-width#128
RanaBug merged 1 commit intostagingfrom
fix/PRO-2560/big-screen-scrolling-max-width

Conversation

@RanaBug
Copy link
Collaborator

@RanaBug RanaBug commented Jul 30, 2024

Description

  • If the user is using a big screen, it can now have access to the infinite scrolling feature of the app.
  • The max width of the page and tiles is set up to 1248px
  • The page-1 of the api data is always showing first, better management of pagination and infinite scrolling together

How Has This Been Tested?

  • Existing unit tests, manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@RanaBug RanaBug requested a review from IAmKio July 30, 2024 09:30
@RanaBug RanaBug self-assigned this Jul 30, 2024
@cloudflare-workers-and-pages
Copy link

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9c2dce3
Status: ✅  Deploy successful!
Preview URL: https://802af3e8.x-e62.pages.dev
Branch Preview URL: https://fix-pro-2560-big-screen-scro.x-e62.pages.dev

View logs

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@RanaBug RanaBug merged commit ea4c677 into staging Jul 31, 2024
@RanaBug RanaBug deleted the fix/PRO-2560/big-screen-scrolling-max-width branch April 3, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants