Skip to content

fix/PRO-2562/same-chain-same-token-server-error#149

Merged
RanaBug merged 2 commits intostagingfrom
fix/PRO-2562/same-chain-same-token-server-error
Aug 14, 2024
Merged

fix/PRO-2562/same-chain-same-token-server-error#149
RanaBug merged 2 commits intostagingfrom
fix/PRO-2562/same-chain-same-token-server-error

Conversation

@RanaBug
Copy link
Collaborator

@RanaBug RanaBug commented Aug 13, 2024

Description

  • Fix internal server error when same token and same chain, now is being handled with no offers and avoiding catching errors.

How Has This Been Tested?

  • Existing unit tests and manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@RanaBug RanaBug requested review from IAmKio and vignesha22 August 13, 2024 13:56
@RanaBug RanaBug self-assigned this Aug 13, 2024
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 13, 2024

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 113b248
Status: ✅  Deploy successful!
Preview URL: https://f63288ae.x-e62.pages.dev
Branch Preview URL: https://fix-pro-2562-same-chain-same.x-e62.pages.dev

View logs

Copy link
Contributor

@vignesha22 vignesha22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RanaBug RanaBug merged commit f3d6321 into staging Aug 14, 2024
@RanaBug RanaBug deleted the fix/PRO-2562/same-chain-same-token-server-error branch April 3, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants