Merged
Conversation
Deploying x with
|
| Latest commit: |
68464ee
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://92a63b72.x-e62.pages.dev |
| Branch Preview URL: | https://fix-pro-2635-wallet-tile-api.x-e62.pages.dev |
IAmKio
requested changes
Sep 3, 2024
Collaborator
IAmKio
left a comment
IAmKio
left a comment
There was a problem hiding this comment.
Just a minor comment but other than that looks good!
src/apps/pillarx-app/api/homeFeed.ts
Outdated
Comment on lines
32
to
33
| export const walletTiledApi = createApi({ | ||
| reducerPath: 'walletTiledApi', |
Collaborator
There was a problem hiding this comment.
walletTiledApi seems like a spelling mistake, is it supposed to be
Suggested change
| export const walletTiledApi = createApi({ | |
| reducerPath: 'walletTiledApi', | |
| export const walletPortfolioTileApi = createApi({ | |
| reducerPath: 'walletPortfolioTileApi', |
src/apps/pillarx-app/api/homeFeed.ts
Outdated
| * Add this to the store | ||
| */ | ||
| addMiddleware(homeFeedApi); | ||
| addMiddleware(walletTiledApi); |
Collaborator
There was a problem hiding this comment.
Suggested change
| addMiddleware(walletTiledApi); | |
| addMiddleware(walletPortfolioTileApi); |
src/apps/pillarx-app/api/homeFeed.ts
Outdated
| addMiddleware(walletTiledApi); | ||
|
|
||
| export const { useGetTilesInfoQuery } = homeFeedApi; | ||
| export const { useGetWalletInfoQuery } = walletTiledApi; |
Collaborator
There was a problem hiding this comment.
And just a reminder to change the name here too
| <TileContainer id='wallet-portfolio-tile-loader' className='p-10 gap-20 tablet:p-5 mobile:p-0 mobile:bg-[#1F1D23] mobile:flex-col mobile:gap-4'> | ||
| <div className='flex flex-col justify-between'> | ||
| <SkeletonLoader $height='40px' $width='200px' $marginBottom='54px' $radius='10px' className='mobile:hidden' /> | ||
| {/* <SkeletonLoader $height='40px' $width='200px' $marginBottom='54px' $radius='10px' className='mobile:hidden' /> */} |
Collaborator
There was a problem hiding this comment.
Did you want to remove this line?
github-actions
bot
temporarily deployed
to
Preview (fix/PRO-2635/wallet-tile-api-update)
github-actions
bot
temporarily deployed
to
Preview (fix/PRO-2635/wallet-tile-api-update)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes