Skip to content

Comments

Add exolix#173

Merged
IAmKio merged 14 commits intopillarwallet:stagingfrom
devexolix:staging
Oct 7, 2024
Merged

Add exolix#173
IAmKio merged 14 commits intopillarwallet:stagingfrom
devexolix:staging

Conversation

@devexolix
Copy link

Description

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@IAmKio
Copy link
Collaborator

IAmKio commented Sep 18, 2024

@devexolix
Copy link
Author

devexolix commented Sep 18, 2024

@devexolix sorry this looks like it's rendering an iframe which is not allowed: https://github.com/pillarwallet/x/pull/173/files#diff-5a58296effc18582ddc8fca3b692f072fbed94a29ab969790e6845fc4dae82dfR93

@IAmKio Yes, we use iframe, but it links to your repository in folder "/public/exolix-static" and you have all the source code and we haven't plugged in any outside code.

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are over 200 files changed here - can i just check did you basically package the whole Exolix website and ship it as an app?

Comment on lines +85 to +94
<div
style={{
display: 'flex',
justifyContent: 'center',
alignItems: 'center',
height: '100vh',
}}
>
<iframe srcDoc={templ} width="100%" style={{ height: '100%' }}></iframe>
</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not possible for you to export templ as a React Component module and then return that here? Is there a reason it needs to be in an iframe?

@devexolix
Copy link
Author

@IAmKio Yes, we pack build our site and add to app, and this is why we need use the iframe because the build version need render in HTML tag and have the own DOM.

@IAmKio IAmKio merged commit fb5b956 into pillarwallet:staging Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants