Skip to content

fix/PRO-2692/boring-avatars-placeholders#175

Merged
RanaBug merged 4 commits intostagingfrom
fix/PRO-2692/boring-avatars-placeholders
Sep 19, 2024
Merged

fix/PRO-2692/boring-avatars-placeholders#175
RanaBug merged 4 commits intostagingfrom
fix/PRO-2692/boring-avatars-placeholders

Conversation

@RanaBug
Copy link
Collaborator

@RanaBug RanaBug commented Sep 18, 2024

Description

  • Token and chain logos placeholder with boring avatars

How Has This Been Tested?

  • Unit tests and manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@RanaBug RanaBug requested a review from IAmKio September 18, 2024 15:16
@RanaBug RanaBug self-assigned this Sep 18, 2024
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 18, 2024

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: bf4814b
Status: ✅  Deploy successful!
Preview URL: https://b11483c4.x-e62.pages.dev
Branch Preview URL: https://fix-pro-2692-boring-avatars.x-e62.pages.dev

View logs

@github-actions github-actions bot temporarily deployed to Preview (fix/PRO-2692/boring-avatars-placeholders) September 18, 2024 16:19 Inactive

const PortfolioOverview = ({ data, isDataLoading }: PortfolioOverviewProps) => {
const [t] = useTranslation();
const accountAddress = useWalletAddress();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - thanks for all the extras! 🙏

@github-actions github-actions bot temporarily deployed to Preview (fix/PRO-2692/boring-avatars-placeholders) September 19, 2024 08:18 Inactive
@RanaBug RanaBug merged commit 295ca6b into staging Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants