Skip to content

Comments

fix/PRO-2690/generic-banner-height#187

Merged
RanaBug merged 2 commits intostagingfrom
fix/PRO-2690/generic-banner-height
Oct 3, 2024
Merged

fix/PRO-2690/generic-banner-height#187
RanaBug merged 2 commits intostagingfrom
fix/PRO-2690/generic-banner-height

Conversation

@RanaBug
Copy link
Collaborator

@RanaBug RanaBug commented Oct 3, 2024

Description

  • Min generic banner height implemented

How Has This Been Tested?

  • Update snapshots and manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@RanaBug RanaBug requested a review from IAmKio October 3, 2024 14:48
@RanaBug RanaBug self-assigned this Oct 3, 2024
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 3, 2024

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: b45e197
Status: ✅  Deploy successful!
Preview URL: https://02ad0d52.x-e62.pages.dev
Branch Preview URL: https://fix-pro-2690-generic-banner.x-e62.pages.dev

View logs

@github-actions github-actions bot temporarily deployed to Preview (fix/PRO-2690/generic-banner-height) October 3, 2024 15:01 Inactive
Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RanaBug RanaBug merged commit 5956041 into staging Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants