Add tooltip component, add tooltip to logout button#189
Add tooltip component, add tooltip to logout button#189IAmKio merged 7 commits intopillarwallet:stagingfrom zbcoding:staging
Conversation
README.md
Outdated
| 2. We have included a `.env.example` file - copy ALL these values to a `.env` file in the project root. This will ensure that you can run PillarX with no issues. | ||
|
|
||
| 3. Run `npm start` at the root. This will run PillarX locally on your machine and launch the website in your default browser. | ||
| 3. Run `npm start` at the root. This will run PillarX locally on your machine and launch the website in your default browser. Login to the wallet at http://localhost:3000/login and enter your email address - Privy will send that email address a login code. |
There was a problem hiding this comment.
There are different ways to login, so I would suggest to change this added sentence to something like: "To access the login page, add to the url "/login". In that way, we leave the user choose how they want to login.
src/components/Tooltip.tsx
Outdated
| import styled from 'styled-components'; | ||
| import Tippy from '@tippyjs/react'; | ||
|
|
||
| export const Tooltip = styled(Tippy)` |
There was a problem hiding this comment.
To keep consistent with the rest of the code, and since this component does not accept any params, could you add it directly to AccountModal.tsx, where it is being used, at the end of the file?
There was a problem hiding this comment.
Moved the style tippy component to the end of the AccountModal file and deleted the Tooltip.tsx file
|
Thank you very much for the suggestion of adding a tooltip component, that's great! I've added a couple of comments for you to review. |
|
PR updated, 3 files are now changed |
3 participants
Description
Add a tooltip component using main theme color. Wrap a component tag with the tooltip and the tooltip will show when user hovers over an element for a while (default: 1 second). Added tooltip to logout icon button.
Change
TopBarIcon id="acount-logout"toTopBarIcon id="account-logout"Added where to login to readme.
How Has This Been Tested?
UI element tested locally
Screenshots (if appropriate):
Types of changes