Conversation
Deploying x with
|
| Latest commit: |
6c96edc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://73b3c3a5.x-e62.pages.dev |
| Branch Preview URL: | https://feat-pro-2905-points-tile.x-e62.pages.dev |
github-actions
bot
temporarily deployed
to
Preview (feat/PRO-2905/Points-Tile)
IAmKio
reviewed
Jan 3, 2025
Comment on lines
+8
to
+11
| const totalSeconds = Math.floor(timestamp / 1000); | ||
| const days = Math.floor(totalSeconds / (24 * 3600)); | ||
| const hours = Math.floor((totalSeconds % (24 * 3600)) / 3600); | ||
| const minutes = Math.floor((totalSeconds % 3600) / 60); |
Collaborator
There was a problem hiding this comment.
Just a note, luxon library might help you better in future 🙏
IAmKio
requested changes
Jan 3, 2025
Collaborator
IAmKio
left a comment
IAmKio
left a comment
There was a problem hiding this comment.
Just a minor point but other than that looks good!
| </div> | ||
| </div> | ||
|
|
||
| <div className="flex desktop:flex-col tablet:flex-row mobile:flex-row desktop:w-[25%] tablet:w-full mobile:w-full h-full bg-container_grey/[.9] rounded-[10px] p-4 pt-8 justify-between gap-4"> |
Collaborator
There was a problem hiding this comment.
Could we make this conditional please on the referal data existing? When we launch this it likely won't exist so we need to hide this column for now
Collaborator
Author
There was a problem hiding this comment.
Ok no worries I added a condition if no code AND no href, then it does not show
|
|
||
| expect(screen.queryByText('My Points Tile')).not.toBeInTheDocument(); | ||
| expect(screen.queryByText('500')).not.toBeInTheDocument(); | ||
| }); |
Collaborator
There was a problem hiding this comment.
Just a note to add a test to hide referals section when not available
github-actions
bot
temporarily deployed
to
Preview (feat/PRO-2905/Points-Tile)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes