Skip to content

Nft types fix#228

Merged
RanaBug merged 3 commits intostagingfrom
feat/PRO-2694/Deposit-App
Jan 13, 2025
Merged

Nft types fix#228
RanaBug merged 3 commits intostagingfrom
feat/PRO-2694/Deposit-App

Conversation

@RanaBug
Copy link
Collaborator

@RanaBug RanaBug commented Jan 13, 2025

Description

  • Fix to recognise which nft it is (ERC721 or ERC1155)
  • Change safeTransferFrom to transferFrom for ERC721
  • Remove deposit support for ERC1155

How Has This Been Tested?

  • Manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@RanaBug RanaBug self-assigned this Jan 13, 2025
@RanaBug RanaBug requested a review from IAmKio January 13, 2025 11:44
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 13, 2025

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8609a7f
Status: ✅  Deploy successful!
Preview URL: https://1be03ab2.x-e62.pages.dev
Branch Preview URL: https://feat-pro-2694-deposit-app.x-e62.pages.dev

View logs

@RanaBug RanaBug marked this pull request as ready for review January 13, 2025 15:43
@github-actions github-actions bot temporarily deployed to Preview (feat/PRO-2694/Deposit-App) January 13, 2025 15:43 Inactive
Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor point and a few cosmetic issues but other than that, looking good!

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops left the wrong response!

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RanaBug RanaBug merged commit 5faefc4 into staging Jan 13, 2025
5 checks passed
@RanaBug RanaBug deleted the feat/PRO-2694/Deposit-App branch April 3, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants