fix/PRO-3125/balance-eth-on-base

[RanaBug]

Description

• Fix to see the ETH balance on base

How Has This Been Tested?

• Manual testing

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

• New Features
  • Expanded native token support on Ethereum and Base chains to now include both standard tokens and their wrapped counterparts for enhanced transaction versatility.

[coderabbitai]

Walkthrough

This pull request updates the token configurations in the blockchain utility file. The nativeTokensByChain object now recognizes both ETH and its wrapped version (WETH) for Ethereum (chain ID 1) and Base (chain ID 8453) by adding the respective WETH addresses alongside the original ETH addresses.

Changes

File	Change Summary
src/.../blockchain.ts	Updated nativeTokensByChain for Ethereum (chain ID 1) and Base (chain ID 8453) by adding WETH addresses alongside the existing ETH token addresses.

Suggested reviewers

• IAmKio

Poem

I'm a rabbit in a code burrow, hopping through each line,
ETH and WETH now join the rhythm, in blockchain they align.
Tokens twirl and dance in a digital delight,
Each update a gentle hop into the future bright.
With a twitch of my nose, I celebrate changes all night!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[IAmKio]

LGTM

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/utils/blockchain.ts (1)

48-59: Consider adding a comment explaining the significance of wrapped tokens in the native tokens list

While the individual comments for each chain are helpful, it might be beneficial to add a brief comment at the top of the nativeTokensByChain object explaining why wrapped versions of native tokens are included in this list and how they're used throughout the application.

This would make it clearer for future developers why both ETH and WETH addresses are considered "native" tokens.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 713898b and 15920e5.

📒 Files selected for processing (1)

• src/utils/blockchain.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: unit-tests
• GitHub Check: build
• GitHub Check: Cloudflare Pages

🔇 Additional comments (2)

src/utils/blockchain.ts (2)

49-52: Good enhancement to include WETH as a native token for Ethereum

Adding the Wrapped ETH (WETH) address to the Ethereum chain configuration is a good practice. This ensures consistency with the Base chain implementation and allows for more flexible handling of ETH in both its native and wrapped forms.

The address 0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2 is the correct canonical WETH address on Ethereum mainnet.

---

55-58: Correctly implements the ETH balance visibility fix for Base

This change directly addresses the PR objective by adding the WETH address for Base chain. The address 0x4200000000000000000000000000000000000006 is the correct WETH contract address on Base.

By including WETH in the native tokens list, the application will now properly recognize and display both ETH and WETH balances on Base, which should resolve the visibility issue mentioned in the PR description.

[cloudflare-workers-and-pages]

Deploying x with    Cloudflare Pages

Latest commit:	15920e5
Status:	✅  Deploy successful!
Preview URL:	https://2475bc49.x-e62.pages.dev
Branch Preview URL:	https://fix-pro-3125-balance-eth-on.x-e62.pages.dev

View logs