add compatibility with signTypedData_v4

[RanaBug]

Description

• Add compatibility with signTypedData_V4 working with signTypedData() on the Etherspot Modular Sdk

How Has This Been Tested?

• Manual Testing

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

• New Features
  • Enhanced wallet connectivity by supporting an updated method for signing typed data, which allows more flexible handling of session proposals and requests.

[coderabbitai]

Walkthrough

A new constant, ETH_SIGN_TYPED_DATA_V4, has been introduced into the WalletConnect functionality. The methods array within the useWalletConnect hook now includes the new constant, and the conditional check has been updated to process both ETH_SIGN_TYPED_DATA and ETH_SIGN_TYPED_DATA_V4 requests. Additionally, the constant is declared in the wallet connection constants file.

Changes

File(s)	Change Summary
src/services/walletConnect.ts, src/utils/walletConnectConstants.ts	Added ETH_SIGN_TYPED_DATA_V4 to the wallet connection functionality and updated the condition to handle both ETH_SIGN_TYPED_DATA and ETH_SIGN_TYPED_DATA_V4.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant WC as WalletConnect Hook
    participant SM as Signing Module
    C->>WC: Send sign request (ETH_SIGN_TYPED_DATA/ETH_SIGN_TYPED_DATA_V4)
    WC->>WC: Check request.method
    WC->>SM: Process signing request
    SM-->>WC: Return signature response
    WC-->>C: Respond with signed data

Loading

Possibly related PRs

• fix transaction hash and erc20 value for walletconnect #260: Enhances wallet connection functionality with similar code-level adjustments in the src/services/walletConnect.ts file.

Suggested reviewers

• IAmKio

Poem

In the code garden, I hop with delight,
New constant in tow, shining so bright.
ETH_SIGN_TYPED_DATA_V4 leaps into view,
Handling requests with a check that's true.
A rabbit's cheer for changes that feel right!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66e94ed and 701f512.

📒 Files selected for processing (1)

• src/services/walletConnect.ts (3 hunks)

🧰 Additional context used

🧬 Code Definitions (1)

src/services/walletConnect.ts (1)

src/utils/walletConnectConstants.ts (2) (2)

• ETH_SIGN_TYPED_DATA (5-5)
• ETH_SIGN_TYPED_DATA_V4 (6-6)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: unit-tests
• GitHub Check: build
• GitHub Check: Cloudflare Pages

🔇 Additional comments (3)

src/services/walletConnect.ts (3)

28-28: Good addition of ETH_SIGN_TYPED_DATA_V4 constant

Adding the constant for v4 typed data signing enhances the wallet's capabilities while maintaining a clean code structure with centralized constants.

---

332-337: LGTM: Added ETH_SIGN_TYPED_DATA_V4 to supported methods

This change correctly registers the v4 signing method in the session proposal handler, allowing dApps to request this capability during connection. The implementation maintains the existing pattern for method registration.

---

462-465:

Details

❓ Verification inconclusive

Correctly updated condition to handle both signing methods

Good implementation of the conditional check that now processes both v4 and the original signing method versions. This ensures backward compatibility while adding support for the newer standard.

---

🏁 Script executed:

#!/bin/bash
# Verify there are no other occurrences of ETH_SIGN_TYPED_DATA that might need similar updates

echo "Checking for other instances of ETH_SIGN_TYPED_DATA that might need updating:"
rg "ETH_SIGN_TYPED_DATA(?!_V4)" --type ts

Length of output: 457

---

Verified conditional update; please manually verify similar patterns using the updated regex command.

The conditional in src/services/walletConnect.ts now correctly handles both signing methods, ensuring support for both the original and v4 standards. However, the initial shell script encountered a regex error due to unsupported look-ahead. To confirm there aren’t any other instances needing a similar update, please re-run the search with PCRE2 enabled—for example:

#!/bin/bash
echo "Checking for other instances of ETH_SIGN_TYPED_DATA that might need updating (using PCRE2):"
rg --pcre2 "ETH_SIGN_TYPED_DATA(?!_V4)" --type ts

Once verified, you can safely conclude that no further changes are required.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cloudflare-workers-and-pages]

Deploying x with    Cloudflare Pages

Latest commit:	701f512
Status:	✅  Deploy successful!
Preview URL:	https://2fcc427e.x-e62.pages.dev
Branch Preview URL:	https://fix-wallet-connect-qa-fixes.x-e62.pages.dev

View logs

[IAmKio]

LGTM