fix/PRO-3014/leaderboard-improvements#264
Merged
Conversation
Contributor
WalkthroughThe changes enhance several leaderboard and points components by introducing wallet address integration and lazy loading in the LeaderboardTab, refining responsive wallet display in UserInfo, and adding dynamic last-fetched timestamp updates in the leaderboard index. Additionally, the PointsFormattedTimestamp component now conditionally renders time values and corrects a typo in its test identifier. Corresponding test updates have been made to support these new functionalities and ensure accurate targeting of elements. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant LT as LeaderboardTab
participant WA as useWalletAddress
participant IO as IntersectionObserver
U->>LT: Load LeaderboardTab component
LT->>WA: Retrieve wallet address
WA-->>LT: Return walletAddress
LT->>IO: Set up IntersectionObserver on loadMoreRef
IO-->>LT: Element visible in viewport
LT->>LT: Invoke handleLoadMore (increment visibleCount)
sequenceDiagram
participant LI as LeaderboardIndex
participant DF as DataFetch
participant TF as formatDistanceToNowStrict
participant Timer as Timer Effect
DF->>LI: Data fetch successful (all-time, weekly)
LI->>LI: Set lastFetched timestamps
Timer->>TF: Trigger periodic update every minute
TF-->>LI: Return formatted timeAgo strings
LI->>LI: Update leaderboard display with new timeAgo values
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying x with
|
| Latest commit: |
dd5e7ea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7e6a1c3a.x-e62.pages.dev |
| Branch Preview URL: | https://fix-pro-3014-leaderboard-imp.x-e62.pages.dev |
IAmKio
requested changes
Mar 24, 2025
Collaborator
IAmKio
left a comment
IAmKio
left a comment
There was a problem hiding this comment.
Looks good, if you could just check that one comment please 🙏
src/apps/leaderboard/components/LeaderboardTab/LeaderboardTab.tsx
Outdated
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
Preview (fix/PRO-3014/leaderboard-improvements)
github-actions
bot
temporarily deployed
to
Preview (fix/PRO-3014/leaderboard-improvements)
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Summary by CodeRabbit
New Features
Bug Fixes/Improvements