Skip to content

balance to be fixes to two decimals#314

Merged
RanaBug merged 2 commits intostagingfrom
feat/PRO-3182/portfolio-tile-refactor
May 23, 2025
Merged

balance to be fixes to two decimals#314
RanaBug merged 2 commits intostagingfrom
feat/PRO-3182/portfolio-tile-refactor

Conversation

@RanaBug
Copy link
Collaborator

@RanaBug RanaBug commented May 23, 2025

Description

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

  • Style

    • Updated wallet balance and USD change displays to consistently show two decimal places.
  • Tests

    • Adjusted test expectations to match the new two-decimal formatting for wallet balances.

@RanaBug RanaBug requested a review from IAmKio May 23, 2025 12:31
@RanaBug RanaBug self-assigned this May 23, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 23, 2025

Walkthrough

The changes update the number formatting logic in the wallet portfolio balance component and its associated test. The custom utility for limiting digits is removed, and numeric values are now formatted using the native toFixed(2) method for two decimal places. The test is updated to expect this new formatting.

Changes

Files Change Summary
src/apps/pillarx-app/components/WalletPortfolioBalance/WalletPortfolioBalance.tsx Removed limitDigitsNumber import and usage; now uses .toFixed(2) for formatting displayed numbers.
src/apps/pillarx-app/components/WalletPortfolioBalance/test/WalletPortfolioBalance.test.tsx Updated test assertion to expect balance formatted with two decimal places (e.g., $1000.00).

Suggested reviewers

  • IAmKio

Poem

Hopping along the balance sheet,
Two decimals now make things neat.
No more limits, no more fuss,
Just .toFixed(2)—that’s enough for us!
With every hop, the numbers gleam,
Portfolio’s tidy, a rabbit’s dream.
🐇💰

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-05-23T12_35_59_961Z-debug-0.log

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5cbf111 and 72f0032.

⛔ Files ignored due to path filters (1)
  • src/apps/pillarx-app/components/MediaGridCollection/tests/__snapshots__/DisplayCollectionImage.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (2)
  • src/apps/pillarx-app/components/WalletPortfolioBalance/WalletPortfolioBalance.tsx (2 hunks)
  • src/apps/pillarx-app/components/WalletPortfolioBalance/test/WalletPortfolioBalance.test.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: unit-tests
  • GitHub Check: lint
  • GitHub Check: build
  • GitHub Check: Cloudflare Pages
🔇 Additional comments (3)
src/apps/pillarx-app/components/WalletPortfolioBalance/WalletPortfolioBalance.tsx (2)

75-76: LGTM! Consistent formatting with toFixed(2).

The change from using limitDigitsNumber to native toFixed(2) method correctly ensures consistent two decimal place formatting for USD change values.


99-99: LGTM! Consistent balance formatting applied.

The total wallet balance now uses toFixed(2) directly, ensuring consistent two decimal place formatting throughout the component.

src/apps/pillarx-app/components/WalletPortfolioBalance/test/WalletPortfolioBalance.test.tsx (1)

103-103: LGTM! Test correctly updated for new formatting.

The test expectation has been properly updated to reflect the new two decimal place formatting ($1000.00 instead of $1000), ensuring consistency with the component changes.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 23, 2025

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 72f0032
Status: ✅  Deploy successful!
Preview URL: https://42fd0ee2.x-e62.pages.dev
Branch Preview URL: https://feat-pro-3182-portfolio-tile.x-e62.pages.dev

View logs

@github-actions github-actions bot temporarily deployed to Preview (feat/PRO-3182/portfolio-tile-refactor) May 23, 2025 12:34 Inactive
@RanaBug RanaBug merged commit 92797f8 into staging May 23, 2025
7 of 8 checks passed
@coderabbitai coderabbitai bot mentioned this pull request May 23, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants