fix receive modal closing and copy address

[RanaBug]

Description

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

• Refactor

  • Improved modal closing behavior by handling outside clicks directly on the modal background, resulting in more localized and reliable event handling.
  • Simplified the copy-to-clipboard functionality for the address display, enhancing the user interface experience.

• Tests

  • Updated tests to accurately simulate clicking outside the modal for closing it, ensuring consistent behavior with the new implementation.

[coderabbitai]

Walkthrough

The code refactors the click-outside-to-close logic in the ReceiveModal component by replacing a global event listener with localized event handling on the modal's outermost div. Corresponding tests are updated to target the modal container directly when simulating outside clicks. The CopyToClipboard usage within the modal is also streamlined for simpler JSX structure.

Changes

File(s)	Change Summary
src/apps/pillarx-app/components/ReceiveModal/ReceiveModal.tsx	Replaces global mousedown event listener with direct onMouseDown handling on the modal container; simplifies CopyToClipboard wrapping and JSX structure. No changes to exported/public API.
src/apps/pillarx-app/components/ReceiveModal/test/ReceiveModal.test.tsx	Updates test to simulate outside click by firing event on modal container instead of document. No API changes.

Poem

A modal once listened to clicks all around,
Now just its own borders keep it safe and sound.
With CopyToClipboard, the code’s less entwined,
Simpler and neater, by design redefined.
🐇✨ Here’s to changes, both subtle and bright,
Making modals behave just right!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm warn config production Use --omit=dev instead.
npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-05-23T16_17_28_345Z-debug-0.log

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/apps/pillarx-app/components/ReceiveModal/ReceiveModal.tsx (1)

92-124: Verify the UX change in CopyToClipboard behavior.

The refactoring changes the copy functionality from icon-only to entire container clickability. This is a significant UX change where users can now click anywhere in the address container to copy, not just the copy icon.

Additionally, the stopPropagation() on the copy icon (line 119) may be redundant since the entire container is now wrapped in CopyToClipboard.

Please verify:

1. Is the expanded clickable area for copying intentional?
2. Consider removing the stopPropagation() on line 119 since it may no longer be necessary:

                  <img
                    src={CopyIcon}
                    alt="copy-evm-address"
                    className="w-3 h-3.5"
-                   onClick={(e) => e.stopPropagation()}
                  />

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 13f4b53 and 06e8882.

⛔ Files ignored due to path filters (1)

• src/apps/pillarx-app/components/MediaGridCollection/tests/__snapshots__/DisplayCollectionImage.test.tsx.snap is excluded by !**/*.snap

📒 Files selected for processing (2)

• src/apps/pillarx-app/components/ReceiveModal/ReceiveModal.tsx (2 hunks)
• src/apps/pillarx-app/components/ReceiveModal/test/ReceiveModal.test.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: lint
• GitHub Check: unit-tests
• GitHub Check: build
• GitHub Check: Cloudflare Pages

🔇 Additional comments (3)

src/apps/pillarx-app/components/ReceiveModal/ReceiveModal.tsx (2)

68-69: LGTM! Improved event handling approach.

The change from global event listener to localized onMouseDown handler is a good improvement. It's more contained, easier to manage, and avoids potential memory leaks from global listeners.

---

75-75: Correct implementation of event propagation control.

The stopPropagation() call properly prevents the modal from closing when clicking inside the modal content, which is the expected behavior.

src/apps/pillarx-app/components/ReceiveModal/test/ReceiveModal.test.tsx (1)

149-152: Excellent test update aligned with component changes.

The test correctly targets the modal container using data-testid instead of the global document, which properly aligns with the refactored event handling approach in the component.

[cloudflare-workers-and-pages]

Deploying x with    Cloudflare Pages

Latest commit:	06e8882
Status:	✅  Deploy successful!
Preview URL:	https://8f8a5a02.x-e62.pages.dev
Branch Preview URL:	https://feat-pro-3182-portfolio-tile.x-e62.pages.dev

View logs