fix/PRO-3316/max-fee-per-gas-issue

[RanaBug]

Description

• Retry mechanism of sending batched transactions and one transaction with max 3 tries and 2 sec delay.

How Has This Been Tested?

• Existing Unit Tests

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

• New Features

  • Added automatic retry for sending transactions when certain gas-related errors occur, improving reliability for both batch and token sends.

• Bug Fixes

  • Improved error handling and status updates when transaction sending fails after multiple attempts.

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

• src/apps/pillarx-app/components/MediaGridCollection/tests/__snapshots__/DisplayCollectionImage.test.tsx.snap is excluded by !**/*.snap

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Error: Could not generate a valid Mermaid diagram after multiple attempts.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21e9999 and 0f0eddc.

⛔ Files ignored due to path filters (1)

• src/apps/pillarx-app/components/MediaGridCollection/tests/__snapshots__/DisplayCollectionImage.test.tsx.snap is excluded by !**/*.snap

📒 Files selected for processing (2)

• src/components/BottomMenuModal/SendModal/SendModalBatchesTabView.tsx (3 hunks)
• src/components/BottomMenuModal/SendModal/SendModalTokensTabView.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Cloudflare Pages

🔇 Additional comments (6)

src/components/BottomMenuModal/SendModal/SendModalBatchesTabView.tsx (4)

1-2: ESLint disable comments are appropriately added for retry logic.

The disabled rules no-await-in-loop and no-plusplus are necessary for the retry mechanism implementation. These are legitimate exceptions to the general rules in this context.

---

8-8: Import addition is correct and necessary.

The ISentBatches type import is required for typing the return value of the new trySend function.

---

159-170: Error handling is robust and well-implemented.

The error handling correctly catches failures from the retry mechanism and properly updates the UI state. The logging and state management are appropriate.

---

210-210: Optional chaining addition improves safety.

Good defensive programming practice to safely access nested properties that might be undefined.

src/components/BottomMenuModal/SendModal/SendModalTokensTabView.tsx (2)

1-2: ESLint disable comments are appropriately added.

Same rationale as the batches file - these are necessary for the retry loop implementation.

---

10-10: Import addition is correct.

The ISentBatches type import is necessary for the retry function typing.

[vignesha22]

LGTM

[IAmKio]

LGTM

[cloudflare-workers-and-pages]

Deploying x with    Cloudflare Pages

Latest commit:	ba12921
Status:	✅  Deploy successful!
Preview URL:	https://2a4ddc8f.x-e62.pages.dev
Branch Preview URL:	https://fix-pro-3316-max-fee-per-gas.x-e62.pages.dev

View logs