fix/PRO-3409/random-crashes

[RanaBug]

Description

• Fix crash when logging out when logged in via walletConnect
• Fix crash with refetch queries

How Has This Been Tested?

• Manual testing

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

• New Features

  • Added automatic retry logic for leaderboard and home feed data requests, improving reliability in case of network issues.

• Refactor

  • Streamlined leaderboard data fetching by removing manual refetch logic and enabling automatic refresh on mount or parameter changes.

• Bug Fixes

  • Improved address validation in wallet session checks to handle invalid or missing addresses safely.

• Documentation

  • Updated function signature documentation for improved clarity on accepted address types.

[coderabbitai]

Walkthrough

The changes introduce retry logic for API requests in both the leaderboard and home feed modules by wrapping their base queries with a retry utility. In the leaderboard UI, query hooks are updated to use automatic refetching, and manual refetch logic is removed. Address validation is improved in the wallet connection utility.

Changes

File(s)	Change Summary
src/apps/leaderboard/api/leaderboard.ts	Refactored API base query to use retry logic with up to 5 retries for failed requests.
src/apps/pillarx-app/api/homeFeed.ts	Refactored API base query to add retry logic with up to 5 retries for failed requests.
src/apps/leaderboard/index.tsx	Updated leaderboard data query hooks to use automatic refetching; removed manual refetch logic and useEffect.
src/utils/walletConnect.ts	Enhanced address validation; updated function to accept nullable addresses and skip invalid addresses in session.

Sequence Diagram(s)

sequenceDiagram
    participant UI
    participant LeaderboardAPI
    participant Server

    UI->>LeaderboardAPI: useGetLeaderboardQuery(params, { refetchOnMountOrArgChange: true })
    loop up to 5 retries on failure
        LeaderboardAPI->>Server: fetch leaderboard data
        alt Success
            Server-->>LeaderboardAPI: Data response
            LeaderboardAPI-->>UI: Data
        else Failure
            Server-->>LeaderboardAPI: Error
        end
    end

Loading

sequenceDiagram
    participant UI
    participant HomeFeedAPI
    participant Server

    UI->>HomeFeedAPI: Query home feed data
    loop up to 5 retries on failure
        HomeFeedAPI->>Server: fetch home feed data
        alt Success
            Server-->>HomeFeedAPI: Data response
            HomeFeedAPI-->>UI: Data
        else Failure
            Server-->>HomeFeedAPI: Error
        end
    end

Loading

Suggested reviewers

• IAmKio

Poem

In fields of code where queries roam,
Retry logic guides them home.
No more manual refetching here—
Automatic updates, loud and clear!
With careful checks on every address,
Our rabbits leap, avoiding mess.
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-04T12_48_24_803Z-debug-0.log

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4101bd8 and 630285c.

📒 Files selected for processing (4)

• src/apps/leaderboard/api/leaderboard.ts (2 hunks)
• src/apps/leaderboard/index.tsx (1 hunks)
• src/apps/pillarx-app/api/homeFeed.ts (1 hunks)
• src/utils/walletConnect.ts (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (2)

src/apps/pillarx-app/api/homeFeed.ts (1)

src/utils/blockchain.ts (1)

• isTestnet (29-35)

src/apps/leaderboard/api/leaderboard.ts (1)

src/utils/blockchain.ts (1)

• isTestnet (29-35)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: build

🔇 Additional comments (6)

src/utils/walletConnect.ts (2)

31-35: Excellent defensive programming for crash prevention.

The addition of null/undefined checks and address validation using isAddress with non-strict mode effectively prevents crashes during WalletConnect logout when invalid addresses are encountered.

---

39-44: Robust address comparison with proper validation.

The enhanced logic correctly validates each session address before comparison, preventing potential crashes from malformed addresses in the session data. The use of isAddressEqual with proper type casting is appropriate for Ethereum address comparison.

src/apps/pillarx-app/api/homeFeed.ts (1)

19-25: Well-structured retry implementation for improved resilience.

The extraction of baseQuery and wrapping it with retry logic (maxRetries: 5) effectively addresses refetching query crashes by handling transient network failures. The separation of concerns makes the code more maintainable.

src/apps/leaderboard/api/leaderboard.ts (2)

1-1: Consistent retry implementation across APIs.

The addition of the retry import aligns with the broader refactoring to add resilience to API calls throughout the application.

---

18-26: Excellent consistency with homeFeed retry pattern.

The implementation follows the exact same pattern as src/apps/pillarx-app/api/homeFeed.ts, ensuring consistent retry behavior across APIs. The 5-retry limit and structure promote maintainability and uniform error handling.

src/apps/leaderboard/index.tsx (1)

50-55: Excellent implementation of automatic refetching.

The addition of { refetchOnMountOrArgChange: true } to all three useGetLeaderboardQuery calls ensures fresh data and complements the retry logic added to the API layer. This reduces complexity by eliminating manual refetch management while improving reliability.

Also applies to: 61-68, 74-81

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cloudflare-workers-and-pages]

Deploying x with    Cloudflare Pages

Latest commit:	630285c
Status:	✅  Deploy successful!
Preview URL:	https://fa24ffc1.x-e62.pages.dev
Branch Preview URL:	https://fix-pro-3409-random-crashes.x-e62.pages.dev

View logs

[IAmKio]

LGTM