Skip to content

Comments

PRO-3408-Volume Leaderboard#332

Merged
vignesha22 merged 2 commits intostagingfrom
PRO-3408-VolumeLeaderboard
Jun 6, 2025
Merged

PRO-3408-Volume Leaderboard#332
vignesha22 merged 2 commits intostagingfrom
PRO-3408-VolumeLeaderboard

Conversation

@vignesha22
Copy link
Contributor

@vignesha22 vignesha22 commented Jun 5, 2025

Description

  • Replaced the current pxPoints leaderboard to volume leaderboard

How Has This Been Tested?

  • Tested locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

  • New Features
    • Leaderboard now displays "Total Swap Amount" in USD instead of "PX Points" for rankings and user stats.
  • Style
    • Updated labels and formatting to reflect the change from points to swap amounts.
  • Tests
    • Enhanced test data to include swap amount and transaction fee fields for improved coverage.
  • Chores
    • Updated API endpoints to use new "volumeleaderboard" URLs.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 5, 2025

"""

Walkthrough

The changes update the leaderboard feature to display "Total Swap Amount" instead of "PX Points." API endpoints are updated to use a new URL prefix, and the data structures, component display, and test mocks are extended to include swap amount and transaction fee metrics in USD. No control flow or exported API changes occur.

Changes

File(s) Change Summary
src/apps/leaderboard/api/leaderboard.ts Updated API base URLs from "pxpoints" to "volumeleaderboard" for both testnet and mainnet environments.
src/apps/leaderboard/components/LeaderboardTab/LeaderboardTab.tsx Replaced all "PX Points" references with "Total Swap Amount"; displays and labels now use swap amount USD fields.
src/apps/leaderboard/components/LeaderboardTab/test/LeaderboardTab.test.tsx Extended test mock data with swap amount and transaction fee fields in USD; updated test assertions to reflect new labels.
src/types/api.ts Added swap amount and transaction fee USD fields to the PointsResult type for both totals and per-chain breakdowns.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant LeaderboardTab
    participant LeaderboardAPI
    participant Backend

    User->>LeaderboardTab: View leaderboard
    LeaderboardTab->>LeaderboardAPI: Fetch leaderboard data (volumeleaderboard endpoint)
    LeaderboardAPI->>Backend: API request (volumeleaderboard)
    Backend-->>LeaderboardAPI: Return data with swap amount USD fields
    LeaderboardAPI-->>LeaderboardTab: Data with swap metrics
    LeaderboardTab-->>User: Display "Total Swap Amount" rankings
Loading

Suggested reviewers

  • IAmKio

Poem

A leaderboard hop, a swap in the sun,
Points have departed, but swaps have begun!
Dollars now tally where PX once stood,
Rabbits rejoice—this change is quite good.
With new fields and labels, the data’s on track,
🥕 Here’s to the swaps—no turning back!
"""

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-06T09_33_15_202Z-debug-0.log


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce99581 and e620a46.

📒 Files selected for processing (1)
  • src/apps/leaderboard/components/LeaderboardTab/test/LeaderboardTab.test.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/apps/leaderboard/components/LeaderboardTab/test/LeaderboardTab.test.tsx
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: lint
  • GitHub Check: unit-tests
  • GitHub Check: build
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vignesha22 vignesha22 requested review from IAmKio and RanaBug June 5, 2025 11:34
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 5, 2025

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: e620a46
Status: ✅  Deploy successful!
Preview URL: https://b846b5de.x-e62.pages.dev
Branch Preview URL: https://pro-3408-volumeleaderboard.x-e62.pages.dev

View logs

Copy link
Collaborator

@RanaBug RanaBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vignesha22 vignesha22 merged commit a4151c7 into staging Jun 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants