fix for gas used to be shown only to migrating users by RanaBug · Pull Request #335 · pillarwallet/x

RanaBug · 2025-06-17T10:08:17Z

Description

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

Bug Fixes
- Updated migration status display to accurately reflect user-specific migration data.

coderabbitai · 2025-06-17T10:08:23Z

Walkthrough

The change updates the isMigrated prop passed to the GasNewDropCard component within the PxPointsSummary.tsx file. Instead of always passing true, it now passes the value of the isUserInMigrationData variable, making the migration state dependent on user-specific data.

Changes

File(s)	Change Summary
src/apps/leaderboard/components/PxPointsSummary/...	Changed `isMigrated` prop for `GasNewDropCard` to use `isUserInMigrationData` instead of `true`

Suggested reviewers

IAmKio
vignesha22

Poem

In the land of props, a change so neat,
Now migration’s logic is truly complete.
No more always true, but user-aware,
The card now checks who’s really there.
A hop, a skip, a code refactor’s delight—
This rabbit approves, the logic’s just right! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-17T10_10_08_000Z-debug-0.log

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/apps/leaderboard/components/PxPointsSummary/PxPointsSummary.tsx (1)
50-54: Consider memoising repetitive look-ups

findMatchingEntry is invoked four times on every render, doing an O(n × m) search each time. Wrapping each call in useMemo (with the relevant data arrays as dependencies) will avoid unnecessary recomputation and reduce CPU churn on large leaderboards.
-const myAllTimeTrading  = findMatchingEntry(allTimeTradingData);
-const myAllTimeMigration = findMatchingEntry(allTimeMigrationData);
-const myAllTimeMerged   = findMatchingEntry(mergedAllTimeData);
-const myWeeklyMerged    = findMatchingEntry(mergedWeeklyTimeData);
+const myAllTimeTrading = useMemo(
+  () => findMatchingEntry(allTimeTradingData),
+  [allTimeTradingData, walletAddress],
+);
+const myAllTimeMigration = useMemo(
+  () => findMatchingEntry(allTimeMigrationData),
+  [allTimeMigrationData, walletAddress],
+);
+const myAllTimeMerged = useMemo(
+  () => findMatchingEntry(mergedAllTimeData),
+  [mergedAllTimeData, walletAddress],
+);
+const myWeeklyMerged = useMemo(
+  () => findMatchingEntry(mergedWeeklyTimeData),
+  [mergedWeeklyTimeData, walletAddress],
+);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 55cc4b9 and 23c0585.

📒 Files selected for processing (1)

src/apps/leaderboard/components/PxPointsSummary/PxPointsSummary.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: lint
GitHub Check: unit-tests
GitHub Check: build

🔇 Additional comments (1)

src/apps/leaderboard/components/PxPointsSummary/PxPointsSummary.tsx (1)

134-137: Dynamic isMigrated flag is a solid fix

Changing the prop from a hard-coded true to the actual isUserInMigrationData state correctly scopes the “gas used” drop card to migrated users only. No further action needed.

cloudflare-workers-and-pages · 2025-06-17T10:13:54Z

Deploying x with Cloudflare Pages

Latest commit:	`23c0585`
Status:	✅ Deploy successful!
Preview URL:	https://704fc66c.x-e62.pages.dev
Branch Preview URL:	https://feat-px-points-migration-boa.x-e62.pages.dev

View logs

fix for gas used to be shown only to migrating users

23c0585

RanaBug requested a review from IAmKio June 17, 2025 10:08

RanaBug self-assigned this Jun 17, 2025

IAmKio approved these changes Jun 17, 2025

View reviewed changes

coderabbitai bot reviewed Jun 17, 2025

View reviewed changes

RanaBug merged commit 7e2a658 into staging Jun 17, 2025
7 of 8 checks passed

This was referenced Jun 19, 2025

Fetch weekly data fixes and other UI minor fixes #341

Merged

Fix tooltip gas used #355

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix for gas used to be shown only to migrating users#335

fix for gas used to be shown only to migrating users#335
RanaBug merged 1 commit intostagingfrom
feat/px-points-migration-board

RanaBug commented Jun 17, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 17, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

cloudflare-workers-and-pages bot commented Jun 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

RanaBug commented Jun 17, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cloudflare-workers-and-pages bot commented Jun 17, 2025

Deploying x with Cloudflare Pages

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RanaBug commented Jun 17, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 17, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)