Skip to content

Fix/sentry#349

Merged
IAmKio merged 20 commits intostagingfrom
fix/sentry
Jun 23, 2025
Merged

Fix/sentry#349
IAmKio merged 20 commits intostagingfrom
fix/sentry

Conversation

@IAmKio
Copy link
Collaborator

@IAmKio IAmKio commented Jun 23, 2025

Description

  • Removed chunking override
  • Modified GH Actions workflow for Sentry soruce maps

How Has This Been Tested?

  • On Github / Cloudflare

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

  • Chores
    • Updated Sentry CLI dependency to the latest version.
    • Improved Sentry source maps workflow for more reliable release creation and deployment tracking.
  • Refactor
    • Adjusted build configuration by removing custom chunk splitting optimization.

@IAmKio IAmKio requested a review from RanaBug June 23, 2025 16:13
@IAmKio IAmKio self-assigned this Jun 23, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 23, 2025

Walkthrough

The updates include a major revision of the Sentry source maps GitHub Actions workflow, removing custom webpack chunk splitting from the configuration, and upgrading the "@sentry/cli" package to a newer version. The workflow now explicitly builds, sets up Sentry releases, and dynamically sets the environment based on the branch.

Changes

File(s) Change Summary
.github/workflows/sentry-sourcemaps.yml Renamed workflow, restructured steps for Node.js setup, build, and Sentry release creation.
config-overrides.js Removed webpack splitChunks optimization for vendor chunking.
package.json Updated "@sentry/cli" dependency version from ^2.21.5 to ^2.46.0.

Poem

A hop, a skip, a Sentry leap,
Our workflow’s now more tidy and neat.
With chunk splits gone and CLI anew,
The build hops forward, strong and true.
On main or staging, maps take flight—
A rabbit’s work, done just right!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 23, 2025

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 91d28cf
Status:🚫  Build failed.

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/sentry-sourcemaps.yml (2)

11-13: Rename job to sentry-sourcemaps and clean up runner config
Renaming clarifies intent; consider removing or moving the commented ubuntu-32gb runner behind a feature flag to prevent confusion in the future.


20-24: Streamline build step and add caching

  • Use npm ci for reproducible installs.
  • Cache ~/.npm with actions/cache@v3 to speed up CI.
  • Consolidate NODE_OPTIONS in the env block.

Apply this diff:

-      - run: npm i
+      - run: npm ci
+      - uses: actions/cache@v3
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
-      - run: |
-          export NODE_OPTIONS="--max_old_space_size=8192"
-          npm run build
-        env:
-          NODE_OPTIONS: --max_old_space_size=8192
+      - run: |
+          npm run build
+        env:
+          NODE_OPTIONS: --max_old_space_size=8192
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b53f20e and 91d28cf.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • .github/workflows/sentry-sourcemaps.yml (1 hunks)
  • config-overrides.js (0 hunks)
  • package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • config-overrides.js
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: unit-tests
  • GitHub Check: lint
  • GitHub Check: build
🔇 Additional comments (2)
package.json (1)

35-35: Upgrade @sentry/cli to ^2.46.0 – ensure compatibility
The version bump aligns with the workflow updates. Please verify the new CLI version against the Sentry changelog for any breaking changes or deprecated flags that could impact your release process.

.github/workflows/sentry-sourcemaps.yml (1)

16-18: Pin to Node 22 – confirm LTS support
Node 22 isn’t an LTS release yet. If you don’t depend on Node 22-specific features, pinning to an LTS (e.g., 18.x or 20.x) may yield more stability.

@IAmKio IAmKio merged commit aef9df8 into staging Jun 23, 2025
5 of 7 checks passed
@IAmKio IAmKio deleted the fix/sentry branch June 23, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants