Conversation
WalkthroughThe updates include a major revision of the Sentry source maps GitHub Actions workflow, removing custom webpack chunk splitting from the configuration, and upgrading the "@sentry/cli" package to a newer version. The workflow now explicitly builds, sets up Sentry releases, and dynamically sets the environment based on the branch. Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/sentry-sourcemaps.yml (2)
11-13: Rename job tosentry-sourcemapsand clean up runner config
Renaming clarifies intent; consider removing or moving the commentedubuntu-32gbrunner behind a feature flag to prevent confusion in the future.
20-24: Streamline build step and add caching
- Use
npm cifor reproducible installs.- Cache
~/.npmwithactions/cache@v3to speed up CI.- Consolidate
NODE_OPTIONSin theenvblock.Apply this diff:
- - run: npm i + - run: npm ci + - uses: actions/cache@v3 + with: + path: ~/.npm + key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }} - - run: | - export NODE_OPTIONS="--max_old_space_size=8192" - npm run build - env: - NODE_OPTIONS: --max_old_space_size=8192 + - run: | + npm run build + env: + NODE_OPTIONS: --max_old_space_size=8192
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
.github/workflows/sentry-sourcemaps.yml(1 hunks)config-overrides.js(0 hunks)package.json(1 hunks)
💤 Files with no reviewable changes (1)
- config-overrides.js
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: unit-tests
- GitHub Check: lint
- GitHub Check: build
🔇 Additional comments (2)
package.json (1)
35-35: Upgrade @sentry/cli to ^2.46.0 – ensure compatibility
The version bump aligns with the workflow updates. Please verify the new CLI version against the Sentry changelog for any breaking changes or deprecated flags that could impact your release process..github/workflows/sentry-sourcemaps.yml (1)
16-18: Pin to Node 22 – confirm LTS support
Node 22 isn’t an LTS release yet. If you don’t depend on Node 22-specific features, pinning to an LTS (e.g., 18.x or 20.x) may yield more stability.
Description
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Summary by CodeRabbit