minor fixes on history update userOp status#364
Conversation
WalkthroughThe changes update the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TransactionInfo Component
participant Blockchain Explorer
User->>TransactionInfo Component: View transaction details
alt displayStatus == 'Confirmed' and displayChainId != '137'
TransactionInfo Component->>User: Show "View transaction" button (uses tx hash)
User->>Blockchain Explorer: Opens transaction URL with hash
else displayStatus == 'Failed' or displayChainId == '137'
TransactionInfo Component->>User: Show "View transaction" button (uses wallet address, failed param)
User->>Blockchain Explorer: Opens explorer URL with wallet address and failed status
end
Possibly related PRs
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying x with
|
| Latest commit: |
73b1673
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9ae15fd0.x-e62.pages.dev |
| Branch Preview URL: | https://fix-history-userop-status-up.x-e62.pages.dev |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/BottomMenuModal/HistoryModal/TransactionInfo.tsx(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: RanaBug
PR: pillarwallet/x#320
File: src/components/BottomMenuModal/HistoryModal/TransactionInfo.tsx:177-182
Timestamp: 2025-05-28T14:30:02.702Z
Learning: In the transaction history tracking feature, chain ID validation is performed earlier in the flow before the values reach the TransactionInfo component, so additional validation at the display level is not needed.
src/components/BottomMenuModal/HistoryModal/TransactionInfo.tsx (1)
Learnt from: RanaBug
PR: pillarwallet/x#320
File: src/components/BottomMenuModal/HistoryModal/TransactionInfo.tsx:177-182
Timestamp: 2025-05-28T14:30:02.702Z
Learning: In the transaction history tracking feature, chain ID validation is performed earlier in the flow before the values reach the TransactionInfo component, so additional validation at the display level is not needed.
🧬 Code Graph Analysis (1)
src/components/BottomMenuModal/HistoryModal/TransactionInfo.tsx (1)
src/utils/blockchain.ts (2)
getBlockScanName(239-258)getBlockScan(218-237)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: unit-tests
- GitHub Check: lint
- GitHub Check: build
🔇 Additional comments (2)
src/components/BottomMenuModal/HistoryModal/TransactionInfo.tsx (2)
231-253: Clarify the combined condition logic for failed transactions and Polygon handling.The condition
(displayStatus === 'Failed' || displayChainId === '137')combines two different scenarios:
- Failed transactions (any chain) → show wallet address
- Polygon transactions (any status) → show wallet address
This creates inconsistent behavior where Polygon transactions are always directed to the wallet address view, regardless of success/failure status.
Please clarify if this is the intended behavior. The current logic means:
- Failed transactions on any chain: wallet address view
- Any transaction on Polygon: wallet address view
- Successful transactions on non-Polygon: transaction hash view
Consider separating these conditions if they serve different purposes:
- {(displayStatus === 'Failed' || displayChainId === '137') && - displayChainId && ( + {displayStatus === 'Failed' && displayChainId && ( + <button>...</button> + )} + {displayChainId === '137' && displayChainId && ( <button>...</button> )}
207-229: Confirm Polygon exclusion from “View transaction”
ThedisplayChainId !== '137'check in TransactionInfo.tsx prevents the “View transaction” button from rendering on confirmed Polygon (chain 137) transactions. Please verify the business rationale (for example, Polygonscan’s current lack of support for EIP-4337 userOps) and confirm whether this special-case guard is still required or can be removed.• File: src/components/BottomMenuModal/HistoryModal/TransactionInfo.tsx (lines 207–229)
| <p className="text-xs white font-normal"> | ||
| Please check the transaction status on{' '} | ||
| {getBlockScanName(Number(displayChainId))}: | ||
| </p> |
There was a problem hiding this comment.
Fix CSS class name for proper Tailwind styling.
The CSS class white should be text-white for consistency with Tailwind CSS naming conventions.
- <p className="text-xs white font-normal">
+ <p className="text-xs text-white font-normal">📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <p className="text-xs white font-normal"> | |
| Please check the transaction status on{' '} | |
| {getBlockScanName(Number(displayChainId))}: | |
| </p> | |
| <p className="text-xs text-white font-normal"> | |
| Please check the transaction status on{' '} | |
| {getBlockScanName(Number(displayChainId))}: | |
| </p> |
🤖 Prompt for AI Agents
In src/components/BottomMenuModal/HistoryModal/TransactionInfo.tsx around lines
170 to 173, the CSS class name "white" is incorrect for Tailwind CSS and should
be changed to "text-white" to apply the proper text color styling.
2 participants
Description
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Summary by CodeRabbit