fix/PRO-3505/add-extra-week-migration-board

[RanaBug]

Description

• Added 4 extra weeks for migration board (until 29th of July 2025)
• After week 8 will continue to display week 8

How Has This Been Tested?

• Existing Unit Tests and Manual Testing

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of migration weeks to ensure data for weeks 5 through 8 is included and that the latest week is shown if the current date is beyond the last migration week.

• Documentation

  • Updated comments to clarify behavior when the current date exceeds the defined migration weeks.

[coderabbitai]

Walkthrough

The logic in the leaderboard utility was updated to extend migration week coverage from four to eight weeks, adjusting the function to return the last week number if the current date exceeds the defined range. Comments were revised to clarify this behavior, but no function signatures or exports were changed.

Changes

File(s)	Change Summary
src/apps/leaderboard/utils/index.tsx	Extended migration week logic to eight weeks, updated comments to reflect new behavior.

Poem

🐇
Eight weeks now hop along the track,
No more stopping, never look back!
Migration weeks stretch far and wide,
With comments clear, there’s naught to hide.
The code now knows just what to seek—
From week one’s start to the eighth week!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-17T11_20_00_719Z-debug-0.log

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7ccd4a and 1a38780.

📒 Files selected for processing (1)

• src/apps/leaderboard/utils/index.tsx (3 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: RanaBug
PR: pillarwallet/x#334
File: src/apps/leaderboard/utils/index.tsx:91-94
Timestamp: 2025-06-17T09:20:44.533Z
Learning: In src/apps/leaderboard/utils/index.tsx, the getLastWeekMigrationData function intentionally uses currentWeek (not lastWeek) for the completedSwapWeek lookup. This is correct business logic - when retrieving last week's migration data, the function should check swap completion against the current week while using lastWeek for points and USD calculations.

src/apps/leaderboard/utils/index.tsx (1)

Learnt from: RanaBug
PR: pillarwallet/x#334
File: src/apps/leaderboard/utils/index.tsx:91-94
Timestamp: 2025-06-17T09:20:44.533Z
Learning: In src/apps/leaderboard/utils/index.tsx, the getLastWeekMigrationData function intentionally uses currentWeek (not lastWeek) for the completedSwapWeek lookup. This is correct business logic - when retrieving last week's migration data, the function should check swap completion against the current week while using lastWeek for points and USD calculations.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: lint
• GitHub Check: unit-tests
• GitHub Check: build

🔇 Additional comments (6)

src/apps/leaderboard/utils/index.tsx (6)

19-22: LGTM! Week ranges correctly implemented.

The four additional weeks (5-8) are properly structured with sequential 7-day intervals, ending on July 29, 2025 as specified in the PR objectives.

---

24-25: Logic change correctly implements the requirement.

The change from returning null to returning 8 after the migration period ensures the leaderboard continues displaying week 8 data indefinitely, which aligns with the PR objective.

---

10-10: Comment accurately reflects the new behavior.

The updated comment correctly documents that the function now returns the last week number instead of null when beyond the migration period.

---

30-30: Comment accurately reflects the new behavior.

The updated comment correctly documents that the function now returns the last week data instead of undefined when beyond the migration period.

---

73-73: Comment accurately reflects the new behavior.

The updated comment correctly documents that the function now returns the last week data instead of undefined when beyond the migration period.

---

12-26: No downstream null-checks for migration week functions found

I searched the entire codebase for any null/undefined checks against getCurrentMigrationWeek, getCurrentWeekMigrationData, and getLastWeekMigrationData—none were found. Since no code relies on a null return value to detect the end of migration, changing the fallback from null to week 8 is safe.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cloudflare-workers-and-pages]

Deploying x with    Cloudflare Pages

Latest commit:	1a38780
Status:	✅  Deploy successful!
Preview URL:	https://f0cd5d4e.x-e62.pages.dev
Branch Preview URL:	https://fix-pro-3505-add-extra-week.x-e62.pages.dev

View logs

[IAmKio]

LGTM!