Skip to content

Update config.yml#463

Closed
chetanbothra wants to merge 1 commit intostagingfrom
e2e
Closed

Update config.yml#463
chetanbothra wants to merge 1 commit intostagingfrom
e2e

Conversation

@chetanbothra
Copy link
Contributor

@chetanbothra chetanbothra commented Nov 25, 2025

Description

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary by CodeRabbit

  • Chores
    • Updated CI/CD pipeline configuration to enhance test infrastructure and reporting processes.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Modified CircleCI configuration to enhance Playwright E2E testing workflow. Changes include adding tooling dependencies, switching clone branch, creating environment configuration file, improving artifact handling, and replacing static Slack reporting with dynamic CircleCI API-driven report URL retrieval.

Changes

Cohort / File(s) Summary
CircleCI E2E Playwright Workflow Configuration
​.circleci/config.yml
Added jq and curl installation; switched e2e repo clone from main to pillarx-playwright branch; created .env file with test mail, staging, sushi, and execution environment variables; modified test execution to continue on error; relocated Playwright artifacts (blob-report, test-results) to /tmp; integrated CircleCI API for dynamic signed artifact URL retrieval in Slack reporting; updated workflow to trigger only e2e-playwright path in PR workflows

Sequence Diagram(s)

sequenceDiagram
    participant CircleCI as CircleCI Job
    participant Env as Environment Setup
    participant Tests as Playwright Tests
    participant API as CircleCI API
    participant Slack as Slack Notification

    CircleCI->>Env: Install jq, curl
    CircleCI->>Env: Create .env file with vars
    CircleCI->>Tests: Clone e2e repo (pillarx-playwright)
    CircleCI->>Tests: npm run test:all
    Tests-->>CircleCI: Artifacts generated (|| continue on error)
    CircleCI->>CircleCI: Move artifacts to /tmp
    
    rect rgb(200, 220, 255)
    Note over CircleCI,Slack: Dynamic Reporting Flow
    CircleCI->>CircleCI: Check .last-run.json exists
    alt .last-run.json found
        CircleCI->>API: Fetch signed artifact URL
        API-->>CircleCI: REPORT_URL
        CircleCI->>Slack: Send results + dynamic REPORT_URL + Job URL
    else .last-run.json missing
        CircleCI-->>Slack: Skip notification
    end
    end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • CircleCI API integration: Verify the signed URL fetching logic correctly constructs the API request and handles potential API failures gracefully
  • .env file creation: Confirm all environment variables are correctly formatted and safely injected without exposing sensitive values
  • Artifact path updates: Validate that all artifact references consistently point to /tmp paths and that store_artifacts configuration reflects the new locations
  • Error handling: Ensure the || true fallback doesn't mask legitimate test failures and that .last-run.json graceful handling prevents notification spam on failures

Possibly related PRs

  • Playright html #406: Modifies the same CircleCI Playwright workflow configuration with overlapping changes to env vars, test commands, artifact handling, and Slack reporting integration.

Suggested reviewers

  • sankhavaramsaitulasiram
  • boonet

Poem

🐰 CircleCI hops with renewed cheer,
Dynamic reports now crystal clear!
Playwright tests dance through the night,
With signed URLs fetched just right.
The artifacts leap to their new home,
While Slack keeps watch on all we roam! 📋✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch e2e

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf3e809 and 999ae2a.

📒 Files selected for processing (1)
  • .circleci/config.yml (2 hunks)

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant