Skip to content

show user friendly error message, show transaction cost on error#53

Merged
poocart merged 1 commit intostagingfrom
fix/cost-on-err-message
Feb 29, 2024
Merged

show user friendly error message, show transaction cost on error#53
poocart merged 1 commit intostagingfrom
fix/cost-on-err-message

Conversation

@poocart
Copy link
Contributor

@poocart poocart commented Feb 28, 2024

Description

  • Updated @etherspot/transaction-kit to display user friendly error messages and fix gas cost,.
  • Added gas cost display upon send/esimation error.
  • Some pragmatic UI decisions on Send modal bottom part to properly display error message on PillarX Beta version.

How Has This Been Tested?

  • Local dapp and tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@poocart poocart requested a review from IAmKio February 28, 2024 09:12
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7e9a0fb
Status: ✅  Deploy successful!
Preview URL: https://1a4440c2.x-e62.pages.dev
Branch Preview URL: https://fix-cost-on-err-message.x-e62.pages.dev

View logs

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poocart poocart merged commit 4421b41 into staging Feb 29, 2024
@poocart poocart deleted the fix/cost-on-err-message branch February 29, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants