Skip to content

Feature/send modal hook txs batching#56

Merged
poocart merged 2 commits intostagingfrom
feature/send-modal-hook-txs-batching
Mar 1, 2024
Merged

Feature/send modal hook txs batching#56
poocart merged 2 commits intostagingfrom
feature/send-modal-hook-txs-batching

Conversation

@poocart
Copy link
Contributor

@poocart poocart commented Feb 29, 2024

Description

  • Added a way to send batched transactions involved from
  • Breaking change: renamed show bottom menu modal as showTransactionCofirmation.
  • Created simple "Batched Transactions" app to test batched transactions.
  • Added development/:appId route to test app navigation in development.

How Has This Been Tested?

  • Local dapp and tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@poocart poocart changed the base branch from staging to feature/user-tx-safety-warnings February 29, 2024 13:22
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 29, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 38a2da5
Status: ✅  Deploy successful!
Preview URL: https://846b3939.x-e62.pages.dev
Branch Preview URL: https://feature-send-modal-hook-txs.x-e62.pages.dev

View logs


const [chainId, setChainId] = React.useState<number>(+chainOptions[0]?.value);
const { show } = useBottomMenuModal();
const { showTransactionConfirmation } = useBottomMenuModal();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels much better 👍

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - batching 🚀

Base automatically changed from feature/user-tx-safety-warnings to staging March 1, 2024 11:26
@poocart poocart merged commit c722e8b into staging Mar 1, 2024
@poocart poocart deleted the feature/send-modal-hook-txs-batching branch March 1, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants