Conversation
Deploying x with
|
| Latest commit: |
9164a91
|
| Status: | ⚡️ Build in progress... |
IAmKio
reviewed
Mar 29, 2024
Collaborator
IAmKio
left a comment
IAmKio
left a comment
There was a problem hiding this comment.
Just one question about a particular behaviour i've seen but other than that LGTM
| const ModalContent = styled.div` | ||
| width: 350px; | ||
| min-height: 350px; // fixed height only for preview | ||
| width: 336px; |
Collaborator
There was a problem hiding this comment.
This might not be the right place, but when the modal is active you can only dismiss it by clicking the vertical height whitespace within the 336px modal container, but not outside it. Would this benefit from an outder container spanning 100% width that receives the event to dismiss the modal?
Contributor
Author
There was a problem hiding this comment.
oh ok, interesting, I will take a look, Overlay component supposed to take care of it, maybe I didn't notice it not working with recent changes
Contributor
Author
There was a problem hiding this comment.
hmm checked and cannot replicate, did u check on this branch?
IAmKio
approved these changes
Mar 29, 2024
Fix/auth landing navigation fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@privy-io/react-authto1.59.7@etherspot/transaction-kitto0.11.0and applied related changesBottomMenucomponent with new UI designHow Has This Been Tested?
Screenshots (if appropriate):
Types of changes