Skip to content

Feature/fab history new UI#67

Merged
poocart merged 4 commits intostagingfrom
feature/fab-history-new-ui
Apr 11, 2024
Merged

Feature/fab history new UI#67
poocart merged 4 commits intostagingfrom
feature/fab-history-new-ui

Conversation

@poocart
Copy link
Contributor

@poocart poocart commented Apr 10, 2024

Description

  • Adds new UI for bottom menu history modal.
  • Fixes bottom menu modals scrolling issue.
  • Added history local storage for faster loads.
  • Fixed 404 page style.

How Has This Been Tested?

  • Local dapp and tests.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@poocart poocart requested a review from IAmKio April 10, 2024 12:14
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 10, 2024

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: cc79b88
Status: ✅  Deploy successful!
Preview URL: https://c0db157d.x-e62.pages.dev
Branch Preview URL: https://feature-fab-history-new-ui.x-e62.pages.dev

View logs

@github-actions github-actions bot temporarily deployed to Preview (feature/fab-history-new-ui) April 10, 2024 12:15 Inactive
@github-actions github-actions bot temporarily deployed to Preview (feature/fab-history-new-ui) April 10, 2024 12:18 Inactive
Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor points but other than that - LGTM

Copy link
Collaborator

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@poocart poocart merged commit 546ef04 into staging Apr 11, 2024
@poocart poocart deleted the feature/fab-history-new-ui branch April 11, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants