Skip to content

Feature/fab account new UI#68

Merged
IAmKio merged 2 commits intostagingfrom
feature/fab-account-new-ui
Apr 13, 2024
Merged

Feature/fab account new UI#68
IAmKio merged 2 commits intostagingfrom
feature/fab-account-new-ui

Conversation

@poocart
Copy link
Contributor

@poocart poocart commented Apr 12, 2024

Description

  • New design and structure for Accounts modal.
  • Fully replaces balances and nfts API to Etherspot Prime.
  • Other fixes and improvements.

How Has This Been Tested?

  • Local dapp and tests.

Screenshots (if appropriate):

image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@poocart poocart requested a review from IAmKio April 12, 2024 13:07
@cloudflare-workers-and-pages
Copy link

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 007eb89
Status: ✅  Deploy successful!
Preview URL: https://685ef866.x-e62.pages.dev
Branch Preview URL: https://feature-fab-account-new-ui.x-e62.pages.dev

View logs

const allNfts = useMemo(() => {
if (!accountAddress) return [];

return visibleChains.reduce<{ nft: Nft, collection: NftCollection, chain: Chain }[]>(( all, chain) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return visibleChains.reduce<{ nft: Nft, collection: NftCollection, chain: Chain }[]>(( all, chain) => {
return visibleChains.reduce<{ nft: Nft, collection: NftCollection, chain: Chain }[]>((all, chain) => {

@IAmKio IAmKio merged commit 64df819 into staging Apr 13, 2024
@IAmKio IAmKio deleted the feature/fab-account-new-ui branch April 13, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants