feat/PRO-2400/portofolio-overview-tile#78
Merged
Conversation
Deploying x with
|
| Latest commit: |
785324d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://202edcdd.x-e62.pages.dev |
| Branch Preview URL: | https://feat-pro-2400-portofolio-ove.x-e62.pages.dev |
IAmKio
requested changes
May 30, 2024
Collaborator
IAmKio
left a comment
IAmKio
left a comment
There was a problem hiding this comment.
Fantastic work! 🚀 Just a few comments, ignore the line endling comments and anything re: code style as we'll sort that out later 🙏
src/apps/pillarx-app/components/PillarXLogo/test/PillarXLogo.test.tsx
Outdated
Show resolved
Hide resolved
src/apps/pillarx-app/components/PillarXLogo/test/__snapshots__/PillarXLogo.test.tsx.snap
Show resolved
Hide resolved
|
|
||
| const totalPnl24h = pnl24hRealized + pnl24hUnrealized; | ||
|
|
||
| const percentageChange = (totalPnl24h / (total_wallet_balance || 0)) * 100; |
Collaborator
There was a problem hiding this comment.
total_wallet_balance || 0 - okay i can see that there's only once instance where total_wallet_balance is used here hence the || 0. If you think we may use it more - worth adding a default
Collaborator
Author
There was a problem hiding this comment.
Ok should I add the default as an address zero? (0x0000...)?
src/apps/pillarx-app/components/PortofolioOverview/PortofolioOverview.tsx
Outdated
Show resolved
Hide resolved
src/apps/pillarx-app/components/TileContainer/test/__snapshots__/TileContainer.test.tsx.snap
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
Preview (feat/PRO-2400/portofolio-overview-tile)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes