Conversation
IAmKio
commented
Jun 5, 2024
IAmKio
commented
- Reworked app loading
- Added ability to load a development app from the local .env file
- Added stronger checks / error handling around loading apps
- Updated README
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11546855 | Triggered | Generic High Entropy Secret | 83873cd | .env.example | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Deploying x with
|
| Latest commit: |
f02e509
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0065617c.x-e62.pages.dev |
| Branch Preview URL: | https://improve-app-development.x-e62.pages.dev |
src/apps/index.ts
Outdated
| return apps; | ||
| }, {}); | ||
| } | ||
| // eslint-disable-next-line no-console |
There was a problem hiding this comment.
this comment can be removed
| * Finally, did we have a REACT_APP_PX_DEVELOPMENT_ID environment variable set? | ||
| * Attempt to load this also. | ||
| */ | ||
| if (process.env.REACT_APP_PX_DEVELOPMENT_ID) { |
There was a problem hiding this comment.
Just one question here, what if this env variable is an empty string or there is a mismatch between the name of the app in the apps folder and the name in the env file? Should this error be handled as well, or it should not create an issue?
RanaBug
left a comment
RanaBug
left a comment
There was a problem hiding this comment.
Good to go, just one minor comment
2 participants
