Merged
Conversation
…ite scrolling, fix api data issues
Deploying x with
|
| Latest commit: |
c33317a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3472d37d.x-e62.pages.dev |
| Branch Preview URL: | https://fix-pro-2447-home-feed-api-u.x-e62.pages.dev |
IAmKio
requested changes
Jun 13, 2024
src/apps/pillarx-app/components/TokensHorizontalTile/TokensHorizontalTile.tsx
Outdated
Show resolved
Hide resolved
src/apps/pillarx-app/components/TokensVerticalTile/TokensVerticalTile.tsx
Outdated
Show resolved
Hide resolved
src/apps/pillarx-app/index.tsx
Outdated
|
|
||
| useEffect(() => { | ||
| // when apiData loads, we save it in a state to keep previous data | ||
| if (apiData) { |
Collaborator
There was a problem hiding this comment.
May be worth importing isSuccess from the useGetTilesInfoQuery hook and adding it into the if statement here. This ensures that the request was successful before calling setPageData below otherwise it may load the cached data and we'll see the same tiles loading again
Collaborator
Author
There was a problem hiding this comment.
Yes that's a good point, I've added it in, please check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes