Conversation
|
@DazkStealth do you mind pulling the latest staging into your project please as there are conflicts currently - thank you! |
|
@IAmKio sry haven`t noticed. Done it! |
|
@DazkStealth could you please check the styling naming you're using - once we load your app and then go back to the home feed or open any of the Action Bar menus - the text styles / backgrounds etc have all been overridden. Please see the screenshot below:
|
|
@DazkStealth thanks again for your updated submission - we just noticed that you've overridden the 9cd2ea0#diff-d9cbf41d20b9faa34b9066b78856527aca74367f903adf9fc5b00d03bbab0191R34 |
|
@IAmKio so i think it`s done. |
IAmKio
left a comment
IAmKio
left a comment
There was a problem hiding this comment.
We're nearly there just a few questions and suggestions - thank you!
src/apps/stealthex/components/exchange/form/steps/exchange/views/normal/providers/mercuryo.tsx
Outdated
Show resolved
Hide resolved
src/apps/stealthex/components/exchange/form/steps/exchange/views/normal/providers/simplex.tsx
Outdated
Show resolved
Hide resolved
|
@DazkStealth finally made it through the review - just a few questions, we're nearly there! |
|
@IAmKio Hey! I`ve done what you requested. Apologies for the delay. |
|
@DazkStealth could you please check this error we got whilst running the code checks in this branch: Thanks! |
|
@IAmKio it's done! |
Re-running checks... |
IAmKio
left a comment
IAmKio
left a comment
There was a problem hiding this comment.
LGTM - thanks for being our first app within the PillarX ecosystem! LFG!!! 🚀 Our QA team will test this once it's merged - feel free to merge this when you're ready
|
@IAmKio Looks like i do not have write access to merge it. Can you help me? |
|
@DazkStealth done ✨ |
3 participants
Description
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Adding new app that includes https://www.npmjs.com/package/@stealthex-io/widget