Skip to content

Update README.md#93

Merged
IAmKio merged 3 commits intostagingfrom
improvement/readme-updates
Jun 27, 2024
Merged

Update README.md#93
IAmKio merged 3 commits intostagingfrom
improvement/readme-updates

Conversation

@IAmKio
Copy link
Collaborator

@IAmKio IAmKio commented Jun 25, 2024

Description

  • Updated README's to display an alert box to show that we don't accept iframes

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 25, 2024

Deploying x with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4a1acd7
Status: ✅  Deploy successful!
Preview URL: https://599c5304.x-e62.pages.dev
Branch Preview URL: https://improvement-readme-updates.x-e62.pages.dev

View logs

@github-actions github-actions bot temporarily deployed to Preview (improvement/readme-updates) June 25, 2024 15:09 Inactive
@IAmKio IAmKio requested a review from RanaBug June 25, 2024 15:09
@IAmKio IAmKio self-assigned this Jun 25, 2024
#### The guide below will show you how to get started developing an app. If you have any questions or need support, please get in touch with us via [Discord](https://discord.gg/6MKAy7gv4P) or [Telegram](https://t.me/pillarxdevelopers).

> [!CAUTION]
> We do not accept any app submissions that ultimately result in an iframe tag being rendered! This compromises the security of the PillarX ecosystem as the content inside of an iframe can be changed anytime to something deceptive and it is not a chance we are willing to take. Any app submissions that result in this will not be accepted.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"it is not a chance" => "it is not a risk" maybe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed - thanks!

Copy link
Collaborator

@RanaBug RanaBug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

PR suggestions
@github-actions github-actions bot temporarily deployed to Preview (feature/waitlist-rtk-integration) June 27, 2024 18:58 Inactive
@IAmKio IAmKio merged commit cede228 into staging Jun 27, 2024
@IAmKio IAmKio deleted the improvement/readme-updates branch July 11, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants