Decode CPU temperature for Python 3 support #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like the test failure is that Python 3.4 is missing in that environment? Not sure why the rest were cancelled, unless a maintainer did it. I've manually checked this with 3.7.3, although I haven't done any regressions for 2.x, largely because this is copying an existing fix from another Pimoroni repo with BME280 code. |
Member
|
Tests auto-cancel when something explodes, looks like I've fixed them in the interim. If you have the time/inclination then a rebased PR would be welcome. Thank you. |
This ports the changes from pimoroni/enviroplus-python#23 , where this same function is copied.
Contributor
Author
|
Been a while since I've done GitHub flow, but believe that's got you a clean rebase onto current head. |
Member
|
That seems to have done the trick, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the changes from pimoroni/enviroplus-python#23 , where this same function is copied.