Improvements for #28 (Temperature compensation without sub process) #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2019
Merged
Gadgetoid
force-pushed
the
temp-compensation
branch
from
2b95b16 to
0456541
Compare
Gadgetoid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After tweaking
compensate-temperature.pyit struck me that arbitrarily changing the source of temperature compensation may adversely affect long term readfings where the user updates their code.This PR should fix the remaining instances of using a
vcgencmd measure_tempsubprocess in lieu of just reading the appropriate filesystem node, but we should probably merge it cautiously. FAO @sandyjmacdonald