Skip to content

vdir: use custom implementation of atomic_write#1393

Closed
mathstuf wants to merge 1 commit intopimutils:masterfrom
mathstuf:remove-atomicwrites-usage
Closed

vdir: use custom implementation of atomic_write#1393
mathstuf wants to merge 1 commit intopimutils:masterfrom
mathstuf:remove-atomicwrites-usage

Conversation

@mathstuf
Copy link
Contributor

@mathstuf mathstuf commented Feb 12, 2025

The atomicwrites library has been abandoned.

This implementation is a bit stripped down a bit from what the library provided.

Fixes: #1387

@mathstuf mathstuf force-pushed the remove-atomicwrites-usage branch 5 times, most recently from d80da54 to efd186f Compare February 12, 2025 22:57
WhyNotHugo
WhyNotHugo reviewed Feb 12, 2025
View reviewed changes
@mathstuf mathstuf force-pushed the remove-atomicwrites-usage branch 2 times, most recently from dc3541c to 2ebadd4 Compare February 13, 2025 00:08
WhyNotHugo
WhyNotHugo reviewed Feb 13, 2025
View reviewed changes
@mathstuf mathstuf force-pushed the remove-atomicwrites-usage branch 2 times, most recently from 8817e10 to 48dabad Compare February 13, 2025 00:54
@mathstuf mathstuf marked this pull request as ready for review February 13, 2025 00:55
@mathstuf mathstuf force-pushed the remove-atomicwrites-usage branch from 48dabad to 9cf674d Compare February 13, 2025 13:05
WhyNotHugo
WhyNotHugo reviewed Feb 13, 2025
View reviewed changes
@mathstuf mathstuf force-pushed the remove-atomicwrites-usage branch from 9cf674d to 786ffbf Compare February 14, 2025 08:36
WhyNotHugo
WhyNotHugo approved these changes Feb 14, 2025
View reviewed changes
Copy link
Member

@WhyNotHugo WhyNotHugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Haven't had a change to properly test it yet.

@mathstuf
Copy link
Contributor Author

mathstuf commented Feb 21, 2025

Alas, it is one of those pieces of code where all of the "interesting" behavior is along the error path :/ .

@mathstuf @WhyNotHugo
vdir: use custom implementation of atomic_write
62031dc 
The `atomicwrites` library has been abandoned.

This implementation is a bit stripped down a bit from what the library
provided.

Fixes: pimutils#1387
@WhyNotHugo WhyNotHugo force-pushed the remove-atomicwrites-usage branch from 786ffbf to 62031dc Compare February 21, 2025 13:49
@WhyNotHugo
Copy link
Member

WhyNotHugo commented Feb 21, 2025

Applied via 62031dc

@WhyNotHugo WhyNotHugo closed this Feb 21, 2025
@mathstuf mathstuf deleted the remove-atomicwrites-usage branch February 21, 2025 14:36
mathstuf added a commit to mathstuf/khard that referenced this pull request Jul 10, 2025
@mathstuf
atomicwrites: replace with open-coded variant
e4c3e8f 
Lifted from pimutils/khal#1393 (which I also authored). Note that `khal`
used `mode='wb'` everywhere while `khard` uses the `atomicwrites`
default mode of `w`.

Fixes: lucc#342
mathstuf added a commit to mathstuf/todoman that referenced this pull request Jul 10, 2025
@mathstuf
model: remove atomicwrites dependency
6a79e1a 
Lifted from pimutils/khal#1393 (which I also authored).

Fixes: pimutils#582
mathstuf added a commit to mathstuf/todoman that referenced this pull request Jul 10, 2025
@mathstuf
model: remove atomicwrites dependency
122eac7 
Lifted from pimutils/khal#1393 (which I also authored).

Fixes: pimutils#582
@mathstuf mathstuf mentioned this pull request Jul 10, 2025
Closed
mathstuf added a commit to mathstuf/todoman that referenced this pull request Jul 10, 2025
@mathstuf
model: remove atomicwrites dependency
e0782bd 
Lifted from pimutils/khal#1393 (which I also authored).

Fixes: pimutils#582
mathstuf added a commit to mathstuf/khard that referenced this pull request Jul 10, 2025
@mathstuf
atomicwrites: replace with open-coded variant
129ca27 
Lifted from pimutils/khal#1393 (which I also authored). Note that `khal`
used `mode='wb'` everywhere while `khard` uses the `atomicwrites`
default mode of `w`.

Fixes: lucc#342
mathstuf added a commit to mathstuf/khard that referenced this pull request Jul 10, 2025
@mathstuf
atomicwrites: replace with open-coded variant
e23452c 
Lifted from pimutils/khal#1393 (which I also authored). Note that `khal`
used `mode='wb'` everywhere while `khard` uses the `atomicwrites`
default mode of `w`.

Fixes: lucc#342
mathstuf added a commit to mathstuf/khard that referenced this pull request Jul 10, 2025
@mathstuf
atomicwrites: replace with open-coded variant
5d51d2d 
Lifted from pimutils/khal#1393 (which I also authored). Note that `khal`
used `mode='wb'` everywhere while `khard` uses the `atomicwrites`
default mode of `w`.

Fixes: lucc#342
mathstuf added a commit to mathstuf/khard that referenced this pull request Jul 10, 2025
@mathstuf
atomicwrites: replace with open-coded variant
500e888 
Lifted from pimutils/khal#1393 (which I also authored). Note that `khal`
used `mode='wb'` everywhere while `khard` uses the `atomicwrites`
default mode of `w`.

Fixes: lucc#342
mathstuf added a commit to mathstuf/spyder that referenced this pull request Jul 10, 2025
@mathstuf
atomicwrites: remove dependency
b7043ca 
The package has been deprecated. Replace usage with open-coded
replacement.

Lifted from pimutils/khal#1393 (which I also authored).

Fixes: spyder-ide#24689
mathstuf added a commit to mathstuf/spyder that referenced this pull request Jul 10, 2025
@mathstuf
atomicwrites: remove dependency
f30a928 
The package has been deprecated. Replace usage with open-coded
replacement.

Lifted from pimutils/khal#1393 (which I also authored).

Fixes: spyder-ide#24689
@mathstuf mathstuf mentioned this pull request Jul 10, 2025
Merged
3 tasks
mathstuf added a commit to mathstuf/spyder that referenced this pull request Jul 11, 2025
@mathstuf
atomicwrites: remove dependency
3ea498d 
The package has been deprecated. Replace usage with open-coded
replacement. Also copy the test suite for the function.

Lifted from pimutils/khal#1393 (which I also authored).

Fixes: spyder-ide#24689
mathstuf added a commit to mathstuf/spyder that referenced this pull request Jul 11, 2025
@mathstuf
atomicwrites: remove dependency
3032a21 
The package has been deprecated. Replace usage with open-coded
replacement. Also copy the test suite for the function.

Lifted from pimutils/khal#1393 (which I also authored).

Fixes: spyder-ide#24689
mathstuf added a commit to mathstuf/spyder that referenced this pull request Jul 11, 2025
@mathstuf
atomicwrites: remove dependency
f09c004 
The package has been deprecated. Replace usage with open-coded
replacement. Also copy the test suite for the function.

Lifted from pimutils/khal#1393 (which I also authored).

Fixes: spyder-ide#24689
mathstuf added a commit to mathstuf/todoman that referenced this pull request Jul 14, 2025
@mathstuf
model: remove atomicwrites dependency
8cc0561 
Lifted from pimutils/khal#1393 (which I also authored).

Fixes: pimutils#582
WhyNotHugo pushed a commit to pimutils/todoman that referenced this pull request Jul 15, 2025
@mathstuf @WhyNotHugo
model: remove atomicwrites dependency
a8be295 
Lifted from pimutils/khal#1393 (which I also authored).

Fixes: #582
mathstuf added a commit to mathstuf/spyder that referenced this pull request Sep 30, 2025
@mathstuf
atomicwrites: remove dependency
c04ba8c 
The package has been deprecated. Replace usage with open-coded
replacement. Also copy the test suite for the function.

Lifted from pimutils/khal#1393 (which I also authored).

Fixes: spyder-ide#24689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WhyNotHugo WhyNotHugo WhyNotHugo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate Away From Unmaintained atomicwrites Library

2 participants

@mathstuf @WhyNotHugo